fix a Hook Args Usage #413
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Wang Qilin <[email protected]>
Contributor
|
No it's not a bug. So the typical way you set prestart should be like: Thought it's not the only way that can work. |
Author
|
@hqhq , thank you for your review, maybe we can't really call it a bug and I have already fix it :) "poststop": [
{
"path": "/usr/sbin/cleanup.sh",
"args": ["-f"]
}
]so I think we can modify this |
Contributor
|
@wangkirin Yeah, I didn't notice the specs examples, by intuition I think it should be the same as golang packages, I opened a PR opencontainers/runtime-spec#255 , let's see how that works. |
Contributor
|
This is working as intended as @hqhq pointed out. |
stefanberger
pushed a commit
to stefanberger/runc
that referenced
this pull request
Sep 8, 2017
Signed-off-by: Vincent Batts <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I try to use prestart hooks , I found a bug about hook args
If I add folllowing contents in
runtime.jsonrunc terminated and return an error , but if I change the args to
I can get the list of files from standouput, even I change
testto any other string such asadfafadsf, it also works, that means the first argument is uselessI think this problem is caused by the
Cmdstruct of golang , in Godocs, it says [1]Args holds command line arguments, including the command as Args[0].so I make a new string slice and insert a
""string in front of currentArgsbeforecmd.Runto slove that[1] https://golang.org/pkg/os/exec/#Cmd
Signed-off-by: Wang Qilin [email protected]