Skip to content

Comments

ci: fix for codespell 2.2#3561

Merged
AkihiroSuda merged 1 commit intoopencontainers:mainfrom
kolyshkin:ci-codespell-2.2
Aug 18, 2022
Merged

ci: fix for codespell 2.2#3561
AkihiroSuda merged 1 commit intoopencontainers:mainfrom
kolyshkin:ci-codespell-2.2

Conversation

@kolyshkin
Copy link
Contributor

@kolyshkin kolyshkin commented Aug 17, 2022

Recently released codespell 2.2 adds some more false positives,
such as:

./Makefile:78: ro ==> to, row, rob, rod, roe, rot
./Makefile:88: ro ==> to, row, rob, rod, roe, rot
./notify_socket.go:51: ro ==> to, row, rob, rod, roe, rot
./LICENSE:128: complies ==> compiles
./go.sum:59: BU ==> BY
./types/features/features.go:17: ro ==> to, row, rob, rod, roe, rot
./libcontainer/rootfs_linux.go:52: ro ==> to, row, rob, rod, roe, rot
./libcontainer/rootfs_linux.go:166: ro ==> to, row, rob, rod, roe, rot
...
./tests/integration/cgroup_delegation.bats:38: inh ==> in
...

To fix:

  • exclude go.sum;
  • add ro and complies to the list of ignored words;
  • s/inh/inherit in cgroup_delegation.bats.

@kolyshkin kolyshkin added area/ci backport/1.1-todo A PR in main branch which needs to be backported to release-1.1 easy-to-review labels Aug 17, 2022
Recently released codespell 2.2 adds some more false positives,
such as:

	./Makefile:78: ro ==> to, row, rob, rod, roe, rot
	./Makefile:88: ro ==> to, row, rob, rod, roe, rot
	./notify_socket.go:51: ro ==> to, row, rob, rod, roe, rot
	./LICENSE:128: complies ==> compiles
	./go.sum:59: BU ==> BY
	./types/features/features.go:17: ro ==> to, row, rob, rod, roe, rot
	./libcontainer/rootfs_linux.go:52: ro ==> to, row, rob, rod, roe, rot
	./libcontainer/rootfs_linux.go:166: ro ==> to, row, rob, rod, roe, rot
	....
	./tests/integration/cgroup_delegation.bats:38: inh ==> in
	...

To fix:
 - exclude go.sum;
 - add ro and complies to the list of ignored words;
 - s/inh/inherit in cgroup_delegation.bats.

Signed-off-by: Kir Kolyshkin <[email protected]>
@kolyshkin kolyshkin marked this pull request as ready for review August 17, 2022 23:58
Copy link
Contributor

@mrunalp mrunalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AkihiroSuda AkihiroSuda merged commit a98ad5e into opencontainers:main Aug 18, 2022
@kolyshkin kolyshkin added backport/1.1-done A PR in main branch which has been backported to release-1.1 and removed backport/1.1-todo A PR in main branch which needs to be backported to release-1.1 labels Aug 18, 2022
@kolyshkin kolyshkin deleted the ci-codespell-2.2 branch August 18, 2022 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/ci backport/1.1-done A PR in main branch which has been backported to release-1.1 easy-to-review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants