[debug] Int test for #3551#3555
Closed
kolyshkin wants to merge 1 commit intoopencontainers:release-1.1from
Closed
Conversation
kolyshkin
force-pushed
the
1.1-test-dev-pts
branch
from
ffa3230 to
40aa4ee
Compare
Contributor
Author
|
Hmm, I am having a problem reproducing this. Perhaps we need to have some special (non-default) device rules, such as those set in containerd. Could you some help with this |
Member
|
@kolyshkin not sure if relevant for the CI environment, but in moby/moby#43960 I noticed that the failures only occurred with SELinux in enforce mode. |
kolyshkin
force-pushed
the
1.1-test-dev-pts
branch
2 times, most recently
from
afe291f to
4cb51db
Compare
Contributor
Author
|
Ah! Finally reproduced that locally: [kir@kir-rhat runc-tst]$ sudo ./runc --systemd-cgroup run -d 234
[kir@kir-rhat runc-tst]$ sudo ./runc --systemd-cgroup exec -t 234 sh -c 'ls -l /proc/self/fd/0; echo 123'
lrwx------ 1 root root 64 Aug 17 22:13 /proc/self/fd/0 -> /dev/pts/0
123
[kir@kir-rhat runc-tst]$ sudo ./runc --systemd-cgroup exec -t 234 sh -c 'ls -l /proc/self/fd/0; echo 123'
lrwx------ 1 root root 64 Aug 17 22:13 /proc/self/fd/0 -> /dev/pts/0
123
[kir@kir-rhat runc-tst]$ sudo systemctl daemon-reload
[kir@kir-rhat runc-tst]$ sudo ./runc --systemd-cgroup exec -t 234 sh -c 'ls -l /proc/self/fd/0; echo 123'
ERRO[0000] exec failed: unable to start container process: open /dev/pts/0: operation not permitted |
kolyshkin
force-pushed
the
1.1-test-dev-pts
branch
from
4cb51db to
68b62dd
Compare
Contributor
Author
Ah! It was missing |
kolyshkin
force-pushed
the
1.1-test-dev-pts
branch
from
68b62dd to
7d420d8
Compare
v2: use daemon-reexec v3: require root to reload systemd v4: use exec -t Signed-off-by: Kir Kolyshkin <[email protected]>
kolyshkin
force-pushed
the
1.1-test-dev-pts
branch
from
7d420d8 to
11bfa2a
Compare
Contributor
Author
|
OK, the test fails for For some reason it does not fail for CentOS 7 -- I guess the version of systemd in there does not reload device rules upon |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Making sure the test fails before the fix (for #3559 / #3554)