libct/cg/sd: check dbus.ErrClosed instead of isDbusError#3475
Merged
kolyshkin merged 1 commit intoopencontainers:mainfrom May 20, 2022
Merged
libct/cg/sd: check dbus.ErrClosed instead of isDbusError#3475kolyshkin merged 1 commit intoopencontainers:mainfrom
kolyshkin merged 1 commit intoopencontainers:mainfrom
Conversation
chenk008
force-pushed
the
fix_dbus_connection_closed
branch
from
db66075 to
39335dd
Compare
Signed-off-by: Kang Chen <[email protected]>
chenk008
force-pushed
the
fix_dbus_connection_closed
branch
from
39335dd to
0ca0bb9
Compare
AkihiroSuda
approved these changes
May 20, 2022
kolyshkin
approved these changes
May 20, 2022
Contributor
kolyshkin
left a comment
kolyshkin
left a comment
There was a problem hiding this comment.
LGTM, thanks for catching this.
Need a backport to 1.1 and maybe even 1.0.
kolyshkin
added
backport/1.0-todo
kolyshkin
added
backport/1.1-done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes dbus.ErrClosed checker in "retry on dbus disconnect" logic, introduced in PR #2923.
dbus.ErrClosedis not a dbus.Error.It can reproduce in kubelet:
systemctl restart dbusin this nodedbus: connection closed by userSo kubernetes need to bump libct with this fix.
Signed-off-by: Kang Chen [email protected]