[1.0] libct/cg/v1: work around CPU quota period set failure#3115
Merged
mrunalp merged 1 commit intoopencontainers:release-1.0from Aug 11, 2021
Merged
[1.0] libct/cg/v1: work around CPU quota period set failure#3115mrunalp merged 1 commit intoopencontainers:release-1.0from
mrunalp merged 1 commit intoopencontainers:release-1.0from
Conversation
As reported in issue 3084, sometimes setting CPU quota period fails when a new period is lower and a parent cgroup has CPU quota limit set. This happens as in cgroup v1 the quota and the period can not be set together (this is fixed in v2), and since the period is being set first, new_limit = old_quota/new_period may be higher than the parent cgroup limit. The fix is to retry setting the period after the quota, to cover all possible scenarios. Add a test case to cover a regression caused by an earlier version of this patch (ignoring a failure of setting invalid period when quota is not set). Signed-off-by: Kir Kolyshkin <[email protected]> (cherry picked from commit 1b77ebe) Signed-off-by: Kir Kolyshkin <[email protected]>
kolyshkin
changed the title
kolyshkin
added
backport/1.0-todo
kolyshkin
added
backport/1.0-pr
AkihiroSuda
approved these changes
Aug 10, 2021
mrunalp
approved these changes
Aug 11, 2021
This was referenced Aug 11, 2021
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a partial backport of #3090 (first commit -- the fix itself -- only) to release-1.0 branch. Test case and cleanups are omitted as those are too big and do not add much value to this branch.
As reported in issue #3084, sometimes setting CPU quota period fails
when a new period is lower and a parent cgroup has CPU quota limit set.
This happens as in cgroup v1 the quota and the period can not be set
together (this is fixed in v2), and since the period is being set first,
new_limit = old_quota/new_periodmay be higher than the parent cgrouplimit.
The fix is to retry setting the period after the quota, to cover all
possible scenarios.
Add a test case to cover a regression caused by an earlier version of
this patch (ignoring a failure of setting invalid period when quota is
not set).
Signed-off-by: Kir Kolyshkin [email protected]
(cherry picked from commit 1b77ebe)
Signed-off-by: Kir Kolyshkin [email protected]
Proposed changelog entry