libct/cg/fs/freezer: make sure to thaw on failure#2918
Merged
AkihiroSuda merged 1 commit intoopencontainers:masterfrom Apr 21, 2021
Merged
libct/cg/fs/freezer: make sure to thaw on failure#2918AkihiroSuda merged 1 commit intoopencontainers:masterfrom
AkihiroSuda merged 1 commit intoopencontainers:masterfrom
Conversation
Function (*FreezerGroup).Set has a few paths where in can return an error. In any case, if an error is returned, we failed to freeze, and we need to thaw to avoid leaving the cgroup in a stuck state. Signed-off-by: Kir Kolyshkin <[email protected]>
mrunalp
approved these changes
Apr 21, 2021
AkihiroSuda
approved these changes
Apr 21, 2021
Member
AkihiroSuda
left a comment
AkihiroSuda
left a comment
There was a problem hiding this comment.
nit: s/Err/retErr/ would be more Go-ish, but not a huge deal, so merging
This was referenced May 6, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Function
(*FreezerGroup).Sethas a few paths where in can return anerror. In any case, if an error is returned, we failed to freeze,
and we need to thaw to avoid leaving the cgroup in a stuck state.
This is a continuation of #2791 and #2774, addressing #2753 and similar bugs.