Validate mounts #2917
Merged
Validate mounts #2917
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per OCI runtime spec, mount destination MUST be absolute. Let's check that and return an error if not. Signed-off-by: Kir Kolyshkin <[email protected]>
Add a check that mount destination is absolute (as per OCI spec). Signed-off-by: Kir Kolyshkin <[email protected]>
AkihiroSuda
approved these changes
Apr 22, 2021
This was referenced Jun 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to OCI spec, mount destination MUST be an absolute path. We never validate it, I think we should.
Add validation to both specconv and configs/validate, and error out on non-abs paths.