Renew dbus connection#2862
Closed
wzshiming wants to merge 3 commits intoopencontainers:masterfrom
Closed
Conversation
cyphar
reviewed
Mar 18, 2021
wzshiming
force-pushed
the
fix/renew-dbus
branch
2 times, most recently
from
dd7cc8f to
56ffd42
Compare
kolyshkin
reviewed
Mar 19, 2021
kolyshkin
reviewed
Mar 19, 2021
kolyshkin
reviewed
Mar 19, 2021
cyphar
requested changes
Mar 19, 2021
wzshiming
force-pushed
the
fix/renew-dbus
branch
from
56ffd42 to
7f89c47
Compare
wzshiming
force-pushed
the
fix/renew-dbus
branch
from
7f89c47 to
65911d9
Compare
Contributor
Author
|
@cyphar @kolyshkin |
kolyshkin
reviewed
Mar 22, 2021
kolyshkin
reviewed
Mar 22, 2021
kolyshkin
reviewed
Mar 22, 2021
kolyshkin
reviewed
Mar 22, 2021
kolyshkin
reviewed
Mar 22, 2021
kolyshkin
reviewed
Mar 22, 2021
wzshiming
force-pushed
the
fix/renew-dbus
branch
from
65911d9 to
75e652f
Compare
kolyshkin
reviewed
Mar 25, 2021
wzshiming
force-pushed
the
fix/renew-dbus
branch
4 times, most recently
from
b9357d6 to
471ea99
Compare
Contributor
Author
|
@kolyshkin |
Contributor
Author
|
Hi @kolyshkin, could you have time to take a look this PR. |
Contributor
Author
|
PING @kolyshkin |
wzshiming
force-pushed
the
fix/renew-dbus
branch
2 times, most recently
from
4a2f7d6 to
a4e640f
Compare
Signed-off-by: Shiming Zhang <[email protected]>
Signed-off-by: Shiming Zhang <[email protected]>
Signed-off-by: Shiming Zhang <[email protected]>
wzshiming
force-pushed
the
fix/renew-dbus
branch
from
a4e640f to
0983ca1
Compare
Contributor
Author
|
How can I continue to advance this PR? |
Contributor
|
@wzshiming I described the idea of retry in place above (#2862 (comment) and #2862 (comment)), and I guess my description was not clear enough. I have took your patches and added retry-in-place on top, please review #2923 |
Contributor
Author
|
@kolyshkin |
This was referenced Apr 29, 2021
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After the current dbus restarts, legacyManager will always return an error 'dbus: connection closed by user'
This PR fixes when dbus returns this error, try to reconnect to ensure that subsequent calls are normal
xref kubernetes/kubernetes#100328
Please review the changes, if there is no problem, I will to add a test.