remove "apparmor" and "selinux" build tags#2709
Merged
mrunalp merged 2 commits intoopencontainers:masterfrom Dec 18, 2020
Merged
remove "apparmor" and "selinux" build tags#2709mrunalp merged 2 commits intoopencontainers:masterfrom
mrunalp merged 2 commits intoopencontainers:masterfrom
Conversation
thaJeztah
requested changes
Dec 15, 2020
Member
thaJeztah
left a comment
thaJeztah
left a comment
There was a problem hiding this comment.
Left some thoughts; @AkihiroSuda @kolyshkin wdyt?
kolyshkin
reviewed
Dec 15, 2020
kolyshkin
reviewed
Dec 15, 2020
The apparmor tag was introduced in a01ed80 (2014) to make cgo dependency on libapparmor optional. However, the cgo dependency was removed in db093f6 (2017), so it is no longer meaningful to keep apparmor build tag. Close opencontainers#2704 Signed-off-by: Akihiro Suda <[email protected]>
The build tag was removed in go-selinux v1.8.0: opencontainers/selinux#132 Signed-off-by: Akihiro Suda <[email protected]>
AkihiroSuda
force-pushed
the
remove-apparmor-selinux-tags
branch
from
181ac6e to
cb26930
Compare
mrunalp
approved these changes
Dec 18, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AppArmor
The "apparmor" tag was introduced in a01ed80 (2014) to make cgo dependency on libapparmor optional.
However, the cgo dependency was removed in db093f6 (2017), so it is no longer meaningful to keep apparmor build tag.
Close #2704
SELinux
The build tag was removed in go-selinux v1.8.0: opencontainers/selinux#132