Skip to content

libcontainer/intelrdt: adjust the file mode#2636

Merged
cyphar merged 1 commit intoopencontainers:masterfrom
KentaTada:refactor-intelrdt-params
Feb 1, 2021
Merged

libcontainer/intelrdt: adjust the file mode#2636
cyphar merged 1 commit intoopencontainers:masterfrom
KentaTada:refactor-intelrdt-params

Conversation

@KentaTada
Copy link
Copy Markdown
Contributor

This commit adjusts the file mode to use the latest golang style
and also changes the file mode value in accordance with default.

This commit is related to #2625

Signed-off-by: Kenta Tada [email protected]

AkihiroSuda
AkihiroSuda previously approved these changes Oct 6, 2020
Comment thread libcontainer/intelrdt/intelrdt.go Outdated
Comment thread libcontainer/intelrdt/intelrdt.go Outdated
Copy link
Copy Markdown
Contributor

@kolyshkin kolyshkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a nit

@AkihiroSuda
Copy link
Copy Markdown
Member

ping @KentaTada

@KentaTada
Copy link
Copy Markdown
Contributor Author

I'm sorry for the late reply.
The remaining discussion item is whether we should adopt the format of "0o".
I think the format of "0o" is easy to read and reduces the bugs like #2625

@kolyshkin
Copy link
Copy Markdown
Contributor

@KentaTada can you please rebase to kick ci?

@KentaTada
Copy link
Copy Markdown
Contributor Author

@kolyshkin I rebased it.

@kolyshkin
Copy link
Copy Markdown
Contributor

Needs a rebase since we moved away from travis-ci

This commit adjusts the file mode to use the latest golang style
and also changes the file mode value in accordance with default.

Signed-off-by: Kenta Tada <[email protected]>
@KentaTada KentaTada force-pushed the refactor-intelrdt-params branch from 29827d9 to 25987d0 Compare January 8, 2021 06:35
@AkihiroSuda
Copy link
Copy Markdown
Member

@kolyshkin PTAL

Copy link
Copy Markdown
Member

@cyphar cyphar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@cyphar cyphar closed this in 4074b47 Feb 1, 2021
@cyphar cyphar merged commit 4074b47 into opencontainers:master Feb 1, 2021
KentaTada pushed a commit to KentaTada/runc that referenced this pull request Mar 8, 2021
This commit adjusts the file mode to use the latest golang style
In addition to that, I changed those modes from 0700 to 0600
as same as opencontainers#2636

Related to opencontainers#2625

Signed-off-by: Kenta Tada <[email protected]>
KentaTada pushed a commit to KentaTada/runc that referenced this pull request Mar 15, 2021
This commit adjusts the file mode to use the latest golang style
In addition to that, I changed those modes from 0700 to 0600
as same as opencontainers#2636

Related to opencontainers#2625

Signed-off-by: Kenta Tada <[email protected]>
KentaTada pushed a commit to KentaTada/runc that referenced this pull request Jul 5, 2021
This commit adjusts the file mode to use the latest golang style
In addition to that, I changed those modes from 0700 to 0600
as same as opencontainers#2636

Related to opencontainers#2625

Signed-off-by: Kenta Tada <[email protected]>
KentaTada pushed a commit to KentaTada/runc that referenced this pull request Jul 5, 2021
This commit adjusts the file mode to use the latest golang style
In addition to that, I changed those modes from 0700 to 0600
as same as opencontainers#2636

Related to opencontainers#2625

Signed-off-by: Kenta Tada <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants