CI: add golangci-lint via github actions#2618
Merged
kolyshkin merged 1 commit intoopencontainers:masterfrom Oct 1, 2020
Merged
CI: add golangci-lint via github actions#2618kolyshkin merged 1 commit intoopencontainers:masterfrom
kolyshkin merged 1 commit intoopencontainers:masterfrom
Conversation
Signed-off-by: Kir Kolyshkin <[email protected]>
Contributor
Author
|
@AkihiroSuda @mrunalp PTAL |
mrunalp
approved these changes
Sep 30, 2020
AkihiroSuda
approved these changes
Sep 30, 2020
Member
|
All the merge commits are failing: https://github.com/opencontainers/runc/runs/1190924966 Is this expected? |
This was referenced Oct 2, 2020
Contributor
Author
Oh well, no. It should only check new changes and apparently it chokes on merge commits. Let me see if there's a way to disable checking master... |
Contributor
Author
|
OK, so it checks only new issues in pull requests, and it checks the master branch as is.
I can turn |
Member
|
Yes, I'd prefer having existing issues fixed, and after that we could only check changes; see #2627 |
Contributor
Author
I mean |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is set to only check the new code, so this should help maintainers to see any new issues introduced by PRs.
To see the example how it works, check kolyshkin#1
Fixes: #2617