cgroup2: cpuset_v2: skip Apply when no limit is specified #2148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Akihiro Suda <[email protected]>
AkihiroSuda
commented
Oct 18, 2019
| @@ -22,11 +22,14 @@ func (s *CpusetGroupV2) Name() string { | |||
| } | |||
|
|
|||
| func (s *CpusetGroupV2) Apply(d *cgroupData) error { | |||
| if d.config.Resources.CpusetCpus == "" && d.config.Resources.CpusetMems == "" { | |||
| return nil | |||
| } | |||
| dir, err := d.path("cpuset") | |||
There was a problem hiding this comment.
not directly related to this PR, but I'm not convinced of d.path() logic in v2 Apply() functions.
We should check controller availability and maybe write cgroup.subtree_control as crun does?
There was a problem hiding this comment.
yes, I think we should try to enable controllers that are needed
|
LGTM |
|
But should we still join the controllers like in v1, even if no limits are set? Do we still have to join everything to collect stats on the processes? |
|
For unified hierarchy, I think joining (writing |
|
LGTM |
This was referenced Oct 25, 2019
AkihiroSuda
changed the title
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Akihiro Suda [email protected]
Fix #2143