Skip to content

Conversation

@tonistiigi
Copy link
Contributor

Starts a new process inside an existing container.

Signed-off-by: Tonis Tiigi [email protected]

exec.go Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: configuratio => configuration

@tonistiigi tonistiigi force-pushed the exec branch 2 times, most recently from 2cad0cf to 0f2c874 Compare August 18, 2015 20:43
exec.go Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you remove all the whitespace ;) plz?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure :)

Signed-off-by: Tonis Tiigi <[email protected]>
@laijs
Copy link
Contributor

laijs commented Aug 20, 2015

I prefer the name enter, the exec is ambiguous

@wking
Copy link
Contributor

wking commented Aug 20, 2015

On Wed, Aug 19, 2015 at 05:34:00PM -0700, Lai Jiangshan wrote:

I prefer the name enter, the exec is ambiguous

There was some discussion of the name for this functionality in #210
as well. I'd mentioned ‘nsenter’ 1 and ‘ip netns exec’ [2](as well
as ‘docker exec’), so it could go either way without being too
surprising. But @duglin 3 and I 4 currently favor ‘exec’ over
‘enter’.

@crosbymichael
Copy link
Member

LGTM

1 similar comment
@mrunalp
Copy link
Contributor

mrunalp commented Aug 21, 2015

LGTM

mrunalp pushed a commit that referenced this pull request Aug 21, 2015
@mrunalp mrunalp merged commit 6d0f60b into opencontainers:master Aug 21, 2015
stefanberger pushed a commit to stefanberger/runc that referenced this pull request Sep 8, 2017
.travis.yml: add go 1.5.1, update from 1.4.2 to 1.4.3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants