libcontainer: cgroup namespaces enabled utility function#1976
Closed
rgulewich wants to merge 1 commit intoopencontainers:masterfrom
Closed
libcontainer: cgroup namespaces enabled utility function#1976rgulewich wants to merge 1 commit intoopencontainers:masterfrom
rgulewich wants to merge 1 commit intoopencontainers:masterfrom
Conversation
Move code for checking if cgroup namespaces are enabled into a utility function that can be used in other projects. Closes opencontainers#1975 Signed-off-by: Rob Gulewich <[email protected]>
Member
|
I'm not a huge fan of this idea personally -- it's an incredibly trivial check and I don't see the benefit of making it a utility function. |
Author
|
moby/moby#38377 was merged without this: closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move code for checking if cgroup namespaces are enabled into a utility function that can be used in other projects.
Fixes #1975.