Skip to content

Fix condition to detect device type in DeviceFromPath#1544

Merged
mrunalp merged 1 commit intoopencontainers:masterfrom
mlaventure:fix-device-from-path
Aug 5, 2017
Merged

Fix condition to detect device type in DeviceFromPath#1544
mrunalp merged 1 commit intoopencontainers:masterfrom
mlaventure:fix-device-from-path

Conversation

@mlaventure
Copy link
Copy Markdown
Contributor

@mlaventure mlaventure commented Aug 3, 2017

Signed-off-by: Kenfe-Mickael Laventure [email protected]

--

Before this fix, /dev/fuse is created as a block device, and docker tries to create /dev/fd as a 0,0 device.

@crosbymichael
Copy link
Copy Markdown
Member

crosbymichael commented Aug 3, 2017

LGTM

Approved with PullApprove

@thaJeztah
Copy link
Copy Markdown
Member

ping @cyphar PTAL

@mrunalp
Copy link
Copy Markdown
Contributor

mrunalp commented Aug 5, 2017

LGTM

Approved with PullApprove

@mrunalp mrunalp merged commit 135b999 into opencontainers:master Aug 5, 2017
@thaJeztah
Copy link
Copy Markdown
Member

Thanks @mrunalp !

@mlaventure mlaventure deleted the fix-device-from-path branch August 6, 2017 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants