cgroups: Make systemd cgroup parent support use specified slices #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mrunal Patel <[email protected]>
|
Still LGTM |
| @@ -446,7 +446,7 @@ func (m *Manager) Set(container *configs.Config) error { | |||
| } | |||
|
|
|||
| func getUnitName(c *configs.Cgroup) string { | |||
| return fmt.Sprintf("%s-%s.scope", c.Parent, c.Name) | |||
| return fmt.Sprintf("%s-%s.scope", c.ScopePrefix, c.Name) | |||
There was a problem hiding this comment.
do we need to check if ScopePrefix was specified?
There was a problem hiding this comment.
I don't think "-xyz.scope" is valid. Pretty sure I saw systemd fail that name once :)
There was a problem hiding this comment.
I think we need to clarify some of the behavior in #141. I will wait for some conclusion there :)
|
@selvik I am going to close this for now and reopen it again later. |
|
Thanks for the prompt response, @mrunalp! |
hqhq
added a commit
to hqhq/runc
that referenced
this pull request
Oct 16, 2015
Pick up opencontainers#119 Fixes: moby/moby#16681 Signed-off-by: Qiang Huang <[email protected]>
hqhq
added a commit
to hqhq/runc
that referenced
this pull request
Dec 3, 2015
Pick up opencontainers#119 Fixes: moby/moby#16681 Signed-off-by: Qiang Huang <[email protected]>
stefanberger
pushed a commit
to stefanberger/runc
that referenced
this pull request
Sep 8, 2017
Remove trailing whitespace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port of docker-archive/libcontainer#549
Signed-off-by: Mrunal Patel [email protected]