MaskPaths: support directory#1068
Merged
Merged
Conversation
This was referenced Sep 23, 2016
Member
|
We should just use the maskedPaths for this. You can handle the not a dir error and change the logic |
For example, the /sys/firmware directory should be masked because it can contain some sensitive files:
- /sys/firmware/acpi/tables/{SLIC,MSDM}: Windows license information:
- /sys/firmware/ibft/target0/chap-secret: iSCSI CHAP secret
Signed-off-by: Akihiro Suda <[email protected]>
AkihiroSuda
force-pushed
the
maskdir
branch
from
September 23, 2016 16:16
0d0fc56 to
5317955
Compare
Member
Author
|
OK, updated PR |
Member
|
LGTM Is there any better alternative to using tmpfs mounts for this? |
Contributor
|
LGTM |
Member
Author
|
@crosbymichael Alternative idea is bind-mounting an empty directory, but it requires managing the empty directory. So I chose tmpfs here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For example, the /sys/firmware directory should be masked because it can contain some sensitive files (moby/moby#26618):
IMO the issue should be fixed but no need to get this PR in v1.0