Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PullApprove is not working #859

Closed
hqhq opened this issue May 31, 2016 · 2 comments
Closed

PullApprove is not working #859

hqhq opened this issue May 31, 2016 · 2 comments
Assignees

Comments

@hqhq
Copy link
Contributor

hqhq commented May 31, 2016

Seems like the reason is we didn't add any repositories to the team runc-maintainers, ping @caniszczyk @crosbymichael can you do that, I think only the owner roles can manage repository access with teams.

@caniszczyk caniszczyk self-assigned this May 31, 2016
@caniszczyk
Copy link
Contributor

Sorry about that, GitHub should really warn you about teams without any associated repos.

This should be fixed now.

@hqhq
Copy link
Contributor Author

hqhq commented May 31, 2016

Thanks.

stefanberger pushed a commit to stefanberger/runc that referenced this issue Sep 8, 2017
Windows: Fix camelCase inconsistencies
stefanberger pushed a commit to stefanberger/runc that referenced this issue Sep 8, 2017
Through f4d221c (Merge pull request opencontainers#880 from
dqminh/wking-linux-only-capabilities-again, 2017-07-05).  The rc6
release picked up an earlier version of these notes, and those entries
are mostly unchanged except for:

* The credentialSpec entry, which was opencontainers#814 for credentialspec and now
  also includes opencontainers#859 for credentialSpec.

* The root(.path) Hyper-V entry, which was opencontainers#820 for root.path and now
  also includes opencontainers#838 for root.  I also moved this into the "breaking
  changes" section, because rc5 Hyper-V configs required root to be
  set, and rc6 Hyper-V configs require it to not be set.  Although
  whether rc5 allowed Hyper-V configs at all is not clear to me.

* Fixed indenting for the typo-fixes entry, as well as a number of
  more recent typo-fix PRs.

Signed-off-by: W. Trevor King <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants