Skip to content

Consider throwing a warning on not absolute mounts destination paths #3944

@rata

Description

@rata

Description

We upgraded from warning to an error when the destination path of a mount is not an absolute path. This was done on commmit: 881e92a

This is causing issues on containerd.

Describe the results you received and expected

When upgrading containerd to use a runc version that includes this commit, several unit and integration test break.

This is in containerd main, so I expect the same will happen in containerd 1.6 and 1.7 too.

To fix it, I had to do several changes and I'm not sure I haven't broke windows with that yet. See the changes in https://github.com/containerd/containerd/pull/8287/commits before "Update runc binary to support idmap mounts", all of them are needed.

I've added a topic in the next containerd community meeting to discuss this (see here), but I wouldn't be surprised if containerd maintainers will be happy if we delay doing this change and they can fix it in some release, let it soak before applying it to other supported versions. Maybe they don't think it is needed, I don't know :)

I'll keep this up to date, but wanted to know your thoughts on making the error a warning.

What version of runc are you using?

These tests were using commit: 867ee90

Although any runc version that includes the commit switching the warning to errors should fail.

Host OS information

No response

Host kernel information

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions