-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Closed
Description
Running runc tests with make test, I see a failing integration test:
bats -t tests/integration/spec.bats
1..3
ok 1 spec generation cwd
ok 2 spec generation --bundle
not ok 3 spec validator
# (in test file tests/integration/spec.bats, line 92)
# `./validate src/runtime-spec/schema/config-schema.json config.json' failed
# runc spec (status=0):
I can see this test is also failing in your CI. I've looked into the cause of this and found something interesting. There's a go get in the test script here that pulls github.com/xeipuuv/gojsonschema.
It seems a change to that dependency is breaking this test because if I add this after the go get:
( cd "${GOPATH}/src/github.com/xeipuuv/gojsonschema" && git reset --hard 6637feb73ee44cd4640bb3def285c29774234c7f )
... then the test passes. Seems like this commit is the culprit.
I'll figure out if the issue lives in runc or gojsonschema then submit a PR to the appropriate repo.
Metadata
Metadata
Assignees
Labels
No labels