-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Comparing changes
Open a pull request
base repository: opencontainers/runc
base: v1.1.0
head repository: opencontainers/runc
compare: v1.1.1
- 20 commits
- 11 files changed
- 7 contributors
Commits on Jan 17, 2022
-
Signed-off-by: Aleksa Sarai <cyphar@cyphar.com>
Configuration menu - View commit details
-
Copy full SHA for d7f7b22 - Browse repository at this point
Copy the full SHA d7f7b22View commit details
Commits on Jan 27, 2022
-
libct: fixStdioPermissions: minor refactoring
Use os/file Chown method instead of bare unix.Fchown as it already have access to underlying fd, and produces nice-looking errors. This allows us to remove our error wrapping and some linter annotations. We still use unix.Fstat since os.Stat access to os-specific fields like uid/gid is not very straightforward. The only change here is to use file name (rather than fd) in the error text. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com> (cherry picked from commit b7fdb68) Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
1Configuration menu - View commit details
-
Copy full SHA for d2939b6 - Browse repository at this point
Copy the full SHA d2939b6View commit details -
libct: fixStdioPermissions: skip chown if not needed
Since we already called fstat, we know the current file uid. In case it is the same as the one we want it to be, there's no point in trying chown. Remove the specific /dev/null check, as the above also covers it (comparing /dev/null uid with itself is true). This also fixes runc exec with read-only /dev for root user. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com> (cherry picked from commit 18c4760) Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 5053a06 - Browse repository at this point
Copy the full SHA 5053a06View commit details -
libct: fixStdioPermissions: ignore EROFS
In case of a read-only /dev, it's better to move on and let whatever is run in a container to handle any possible errors. This solves runc exec for a user with read-only /dev. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com> (cherry picked from commit 146c8c0) Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 986e7c5 - Browse repository at this point
Copy the full SHA 986e7c5View commit details
Commits on Jan 28, 2022
-
Merge pull request #3355 from kolyshkin/1.1-rodev
[1.1] Fix working with read-only /dev
Mrunal Patel authoredJan 28, 2022 Configuration menu - View commit details
-
Copy full SHA for b9460f2 - Browse repository at this point
Copy the full SHA b9460f2View commit details
Commits on Mar 8, 2022
-
ensure the path is a sub-cgroup path
Signed-off-by: lifubang <lifubang@acmcoder.com> (cherry picked from commit 01f00e1) Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 35784a3 - Browse repository at this point
Copy the full SHA 35784a3View commit details -
Merge pull request #3403 from kolyshkin/1.1-exec-subcgroup
[1.1] runc exec --cgroup: ensure the path is a sub-cgroup path
Configuration menu - View commit details
-
Copy full SHA for 51feb42 - Browse repository at this point
Copy the full SHA 51feb42View commit details -
libct/cg/sd/v2: fix ENOENT on cgroup delegation
Apparently, not all files listed in /sys/kernel/cgroup/delegate must exist in every cgroup, so we should ignore ENOENT. Dot not ignore ENOENT on the directory itself though. Change cgroupFilesToChown to not return ".", and refactor it to not do any dynamic slice appending in case we're using the default built-in list of files. Fixes: 35d20c4 Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com> (cherry picked from commit 8c04b98) Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 9619342 - Browse repository at this point
Copy the full SHA 9619342View commit details
Commits on Mar 10, 2022
-
Merge pull request #3404 from kolyshkin/1.1-delegate-enoent
[1.1] libct/cg/sd/v2: fix ENOENT on cgroup delegation
Configuration menu - View commit details
-
Copy full SHA for a3765fb - Browse repository at this point
Copy the full SHA a3765fbView commit details
Commits on Mar 14, 2022
-
configs/validate: looser validation for RDT
Don't require CAT or MBA because we don't detect those correctly (we don't support L2 or L3DATA/L3CODE for example, and in the future possibly even more). With plain "ClosId mode" we don't really care: we assign the container to a pre-configured CLOS without trying to do anything smarter. Moreover, this was a duplicate/redundant check anyway, as for CAT and MBA there is another specific sanity check that is done if L3 or MB is specified in the config. Signed-off-by: Markus Lehtonen <markus.lehtonen@intel.com> (cherry picked from commit 1d5c331) Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for ee7ba6c - Browse repository at this point
Copy the full SHA ee7ba6cView commit details -
Merge pull request #3406 from marquiz/backports/rdt
[1.1] configs/validate: looser validation for RDT
Configuration menu - View commit details
-
Copy full SHA for 6f48ab3 - Browse repository at this point
Copy the full SHA 6f48ab3View commit details
Commits on Mar 28, 2022
-
libct/cg: IsCgroup2HybridMode: don't panic
In case statfs("/sys/fs/cgroup/unified") fails with any error other than ENOENT, current code panics. As IsCgroup2HybridMode is called from libcontainer/cgroups/fs's init function, this means that any user of libcontainer may panic during initialization, which is ugly. Avoid panicking; instead, do not enable hybrid hierarchy support and report the error (under debug level, not to confuse anyone). Basically, replace the panic with "turn off hybrid mode support" (which makes total sense since we were unable to statfs its root). Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 8290c4c - Browse repository at this point
Copy the full SHA 8290c4cView commit details -
Merge pull request #3435 from mrunalp/dont_panic_1.1
[release-1.1] libct/cg: IsCgroup2HybridMode: don't panic
Mrunal Patel authoredMar 28, 2022 Configuration menu - View commit details
-
Copy full SHA for 6bf0a56 - Browse repository at this point
Copy the full SHA 6bf0a56View commit details -
README,libct/README: fix pkg.go.dev badges
What used to be godoc.org is now pkg.go.dev, and while the old URLs still work, they might be broken in the future. Updated badges are generated via https://pkg.go.dev/badge/ Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com> (cherry picked from commit f309a69) Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for ea19181 - Browse repository at this point
Copy the full SHA ea19181View commit details -
README.md: add cirrus-ci badge
Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com> (cherry picked from commit 3618079) Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for db95315 - Browse repository at this point
Copy the full SHA db95315View commit details -
Merge pull request #3438 from kolyshkin/1.1-fix-badges
[1.1] Fix badges
Mrunal Patel authoredMar 28, 2022 Configuration menu - View commit details
-
Copy full SHA for c653632 - Browse repository at this point
Copy the full SHA c653632View commit details -
CI/cirrus: add centos-stream-9
Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com> (cherry picked from commit a9cc993) Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 036cc34 - Browse repository at this point
Copy the full SHA 036cc34View commit details -
Merge pull request #3436 from kolyshkin/1.1-add-centos-stream-9
[1.1] add centos-stream-9
Configuration menu - View commit details
-
Copy full SHA for ae28db1 - Browse repository at this point
Copy the full SHA ae28db1View commit details -
CHANGELOG.md: add 1.1.1 release notes
This also includes the backport of commit e4d23d5, fixing a minor formatting issue. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 2636e1c - Browse repository at this point
Copy the full SHA 2636e1cView commit details -
Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 52de29d - Browse repository at this point
Copy the full SHA 52de29dView commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v1.1.0...v1.1.1