Fix File to Close

hang.jiang · hang.jiang · commit 937ca107c3d2 · 2023-09-01T16:17:13.000+08:00
Signed-off-by: hang.jiang &lt;hang.jiang@daocloud.io&gt;
diff --git a/libcontainer/cgroups/fs/paths.go b/libcontainer/cgroups/fs/paths.go
@@ -83,6 +83,7 @@ func tryDefaultCgroupRoot() string {
 	if err != nil {
 		return ""
 	}
+	defer dir.Close()
 	names, err := dir.Readdirnames(1)
 	if err != nil {
 		return ""
diff --git a/update.go b/update.go
@@ -182,6 +182,7 @@ other options are ignored.
 				if err != nil {
 					return err
 				}
+				defer f.Close()
 			}
 			err = json.NewDecoder(f).Decode(&r)
 			if err != nil {

Original file line number	Diff line number	Diff line change
`@@ -83,6 +83,7 @@ func tryDefaultCgroupRoot() string {`
`83`	`83`	`if err != nil {`
`84`	`84`	`return ""`
`85`	`85`	`}`
	`86`	`+ defer dir.Close()`
`86`	`87`	`names, err := dir.Readdirnames(1)`
`87`	`88`	`if err != nil {`
`88`	`89`	`return ""`
Original file line number	Diff line number	Diff line change
`@@ -182,6 +182,7 @@ other options are ignored.`
`182`	`182`	`if err != nil {`
`183`	`183`	`return err`
`184`	`184`	`}`
	`185`	`+ defer f.Close()`
`185`	`186`	`}`
`186`	`187`	`err = json.NewDecoder(f).Decode(&r)`
`187`	`188`	`if err != nil {`