docs: update references to tool name and invocation #128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyphar
reviewed
Mar 22, 2017
man/oci-image-tool-validate.1.md
Outdated
| % JULY 2016 | ||
| # NAME | ||
| oci-image-tool validate \- Validate one or more image files | ||
| oci-image-tool-validate \- Validate one or more image files |
Member
There was a problem hiding this comment.
There should be a space here and in all the other files, since they're subcommands now.
Member
|
LGTM. As an aside, I would recommend having more descriptive commit messages. For example, I would name your commit something like |
Signed-off-by: zhouhao <[email protected]>
zhouhao3
changed the title
Author
|
@cyphar Thanks for your advice, I did not pay attention to these things before. |
Member
|
LGTM. Thanks. |
Member
|
LGTM |
wking
reviewed
Mar 22, 2017
| @@ -1,8 +1,8 @@ | |||
| % OCI(1) OCI-CREATE-RUNTIME-BUNDLE User Manuals | |||
| % OCI(1) OCI-IMAGE-TOOL User Manuals | |||
Contributor
There was a problem hiding this comment.
I think we want OCI-IMAGE-TOOL-CREATE(1) OCI Image Tool User Manuals here to match the pattern set in Git's GIT-INIT(1) Git Manual (in git-init(1))
Contributor
There was a problem hiding this comment.
Ah, already merged ;). I'll file a follow-up PR.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: zhouhao [email protected]