config: change reproducibility "MUST" to "SHOULD" #611
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As noted in opencontainers#608 (comment) - we shouldn't be mandating that implementers use something like tar-split to facilitate reproducible DiffIDs, but rather recommend it. Signed-off-by: Jonathan Boulle <[email protected]>
Merged
Member
|
fair, though it doesn't say they must use tar-split, it is just an example right? and what's this even saying is that implied by having a tar archive that matches checksum, so how that is achieved is up to the implementer, right? |
Contributor
Author
|
@vbatts see my comment at #608 (comment) , this is probably just the ambiguity of natural language. Nevertheless seems cleaner if we can standardise on the RFC2119-style |
Contributor
|
LGTM
Agreed. @vbatts We could probably relax this altogether. In fact, if the exact |
Member
|
LGTM |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted in
#608 (comment) , we shouldn't be mandating that implementers use something like
tar-split to facilitate reproducible DiffIDs, but rather recommend it.
Signed-off-by: Jonathan Boulle [email protected]