config: minor cleanup #608
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
wking
reviewed
Mar 10, 2017
config.md
Outdated
|
|
||
| A layer DiffID is the digest over the layer's uncompressed tar archive and serialized in the descriptor digest format, e.g., `sha256:a9561eb1b190625c9adb5a9513e72c4dedafc1cb2d4c5236c9a6957ec7dfd5a9`. | ||
| Layers must be packed and unpacked reproducibly to avoid changing the layer DiffID, for example by using tar-split to save the tar headers. | ||
| Layers must be packed and unpacked reproducibly to avoid changing the layer DiffID, for example by using [tar-split][tar-split] to save the tar headers. |
Contributor
There was a problem hiding this comment.
nit: You can just use [tar-split][] to take advantage of the implicit link name shortcut. Removing the redundant link name makes this line slightly easier to read, but it's obviously not a big deal either way.
Signed-off-by: Jonathan Boulle <[email protected]>
Signed-off-by: Jonathan Boulle <[email protected]>
vbatts
reviewed
Mar 13, 2017
|
|
||
| A layer DiffID is the digest over the layer's uncompressed tar archive and serialized in the descriptor digest format, e.g., `sha256:a9561eb1b190625c9adb5a9513e72c4dedafc1cb2d4c5236c9a6957ec7dfd5a9`. | ||
| Layers must be packed and unpacked reproducibly to avoid changing the layer DiffID, for example by using tar-split to save the tar headers. | ||
| Layers must be packed and unpacked reproducibly to avoid changing the layer DiffID, for example by using [tar-split][] to save the tar headers. |
Member
|
LGTM |
stevvooe
reviewed
Mar 14, 2017
|
|
||
| A layer DiffID is the digest over the layer's uncompressed tar archive and serialized in the descriptor digest format, e.g., `sha256:a9561eb1b190625c9adb5a9513e72c4dedafc1cb2d4c5236c9a6957ec7dfd5a9`. | ||
| Layers must be packed and unpacked reproducibly to avoid changing the layer DiffID, for example by using tar-split to save the tar headers. | ||
| Layers must be packed and unpacked reproducibly to avoid changing the layer DiffID, for example by using [tar-split][] to save the tar headers. |
Contributor
There was a problem hiding this comment.
Is this actually a must? I don't think we need to require that implementation require tar-split or that layers be packed reproducibly. Neither are necessary for a working container runtime.
This is more of an implementation note, maybe.
Contributor
Author
There was a problem hiding this comment.
I suppose (?) as written it's not supposed to be an imperative must (i.e. "to avoid changing the headers, it is necessary for layers to be packed reproducibly" rather than "implementers must pack reproducibly") but I think we should probably standardise on RFC2119 language to be clearer. #611
Contributor
|
LGTM Need to address #608 (comment) separately. This should not be a must. |
jonboulle
added a commit
to jonboulle/image-spec
that referenced
this pull request
Mar 14, 2017
As noted in opencontainers#608 (comment) - we shouldn't be mandating that implementers use something like tar-split to facilitate reproducible DiffIDs, but rather recommend it. Signed-off-by: Jonathan Boulle <[email protected]>
Merged
dattgoswami9lk5g
added a commit
to dattgoswami9lk5g/bremlinr
that referenced
this pull request
Jun 6, 2022
As noted in opencontainers/image-spec#608 (comment) - we shouldn't be mandating that implementers use something like tar-split to facilitate reproducible DiffIDs, but rather recommend it. Signed-off-by: Jonathan Boulle <[email protected]>
7c00d
pushed a commit
to 7c00d/J1nHyeockKim
that referenced
this pull request
Jun 6, 2022
As noted in opencontainers/image-spec#608 (comment) - we shouldn't be mandating that implementers use something like tar-split to facilitate reproducible DiffIDs, but rather recommend it. Signed-off-by: Jonathan Boulle <[email protected]>
7c00d
added a commit
to 7c00d/J1nHyeockKim
that referenced
this pull request
Jun 6, 2022
As noted in opencontainers/image-spec#608 (comment) - we shouldn't be mandating that implementers use something like tar-split to facilitate reproducible DiffIDs, but rather recommend it. Signed-off-by: Jonathan Boulle <[email protected]>
laventuraw
added a commit
to laventuraw/Kihara-tony0
that referenced
this pull request
Jun 6, 2022
As noted in opencontainers/image-spec#608 (comment) - we shouldn't be mandating that implementers use something like tar-split to facilitate reproducible DiffIDs, but rather recommend it. Signed-off-by: Jonathan Boulle <[email protected]>
tomalopbsr0tt
added a commit
to tomalopbsr0tt/fabiojosej
that referenced
this pull request
Oct 6, 2022
As noted in opencontainers/image-spec#608 (comment) - we shouldn't be mandating that implementers use something like tar-split to facilitate reproducible DiffIDs, but rather recommend it. Signed-off-by: Jonathan Boulle <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The DiffID exploration doesn't parse as cleanly as it could to me and I'd like
to work on improving it. Starting with some hopefully uncontroversial tweaks.