validate.go: add autodetect #481
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhouhao3
force-pushed
the
auto-test
branch
4 times, most recently
from
f55c888 to
a630600
Compare
Member
|
|
Signed-off-by: zhouhao <[email protected]>
Author
updated |
Author
philips
suggested changes
Jan 18, 2017
Contributor
philips
left a comment
philips
left a comment
There was a problem hiding this comment.
What is the use case for this?
| } | ||
|
|
||
| // Autodect detects the validation type | ||
| func Autodect(f io.ReadSeeker) (string, error) { |
Author
There was a problem hiding this comment.
I moved the image-tools Autodetect function here because I wanted to put the JSON validation in the iamge-spec repo.
Author
There was a problem hiding this comment.
In opencontainers/image-tools#62 more detailed discussion .
Contributor
|
Also, this will cause problems once a solution to #494 lands. |
Contributor
|
#494 has been merged so this is getting closed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move JSON from image-tool: autodect to image-spec，
complete opencontainers/image-tools#62 .
Signed-off-by: zhouhao [email protected]