Skip to content

Conversation

@caniszczyk
Copy link
Contributor

@jonboulle
Copy link
Contributor

jonboulle commented Sep 16, 2016

lgtm

Approved with PullApprove

@wking
Copy link
Contributor

wking commented Sep 16, 2016

On Fri, Sep 16, 2016 at 01:14:10PM -0700, Chris Aniszczyk wrote:

It's nice to see the build status in the README:
https://travis-ci.org/opencontainers/image-spec

Pandoc does not agree 1 ;). Maybe @vbatts will know of a way to
make both sides happy :p.

@philips
Copy link
Contributor

philips commented Sep 21, 2016

Waiting no @vbatts to resolve

@vbatts
Copy link
Member

vbatts commented Sep 21, 2016

@philips
Copy link
Contributor

philips commented Sep 30, 2016

@vbatts so hard no on this?

@caniszczyk
Copy link
Contributor Author

is there a way for pandoc to ignore certain things? not a blocker by any means, it's just nice to see the build status in a very visible manner

@vbatts
Copy link
Member

vbatts commented Oct 1, 2016

ok, so I am a hard no on the badge being in the outputted 'docs'. SO, maybe the README is only a landing for the github project, but the is a proper abstract/TOC/intro for the docs produced?

@vbatts
Copy link
Member

vbatts commented Oct 1, 2016

also, i'm not sure what the situaish is here with the DCO missing. :-\

@jonboulle
Copy link
Contributor

jonboulle commented Oct 4, 2016

That's because I broke the PR by adding a patch through the web interface. Sorry.

SO, maybe the README is only a landing for the github project, but the is a proper abstract/TOC/intro for the docs produced?

Yes, we should do this (see also #246 (comment))

@vbatts
Copy link
Member

vbatts commented Oct 4, 2016

yeah. perhaps that is ideal.

On Tue, Oct 4, 2016 at 3:40 PM, Jonathan Boulle [email protected]
wrote:

That's because I broke the PR by adding a patch. Sorry.

SO, maybe the README is only a landing for the github project, but the is
a proper abstract/TOC/intro for the docs produced?

Yes, we should do this (see also #246 (comment)
#246 (comment)
)


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#319 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAEF6Wt5byDOH7NmWFTi1-b2fYYp4tF0ks5qwlc5gaJpZM4J_TnQ
.

@vbatts
Copy link
Member

vbatts commented Oct 19, 2016

These two commits need to be squashed or both signed or summat

@philips
Copy link
Contributor

philips commented Oct 24, 2016

Ping @caniszczyk

@caniszczyk caniszczyk changed the title Add Travis CI badge to README Add Travis CI and GoReportCard badge to README Oct 26, 2016
@vbatts
Copy link
Member

vbatts commented Nov 1, 2016

kickstarting this on #433

@vbatts vbatts closed this Nov 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants