Add CODEOWNERS, remove .pullapprove.yml#70
Conversation
Signed-off-by: Josh Dolitsky <[email protected]>
|
What's the context? |
|
I assume to get rid of pullapprove. What does CODEOWNERS file add over just replacing pullapprove with github's threshold approve? |
|
Doesn't CODEOWNERS drive github's feature? |
|
I don't think the CODEOWNERS is strictly needed to make the feature work; configuring "number of approvals" should probably be enough. That said, CODEOWNERS will allow automatically request a review from those listed. Not sure though if "Require review from Code Owners" will force all code owners to leave a review (I guess we only need two out of that list)
|
vbatts
left a comment
vbatts
left a comment
There was a problem hiding this comment.
it must be configured in the repo settings.
But LGTM for once we get that done (cc @caniszczyk )
|
LGTM (enabled the "Require a pull request before merging") setting |
7 participants
No description provided.