Describe single-request monolithic upload behavior#239
Merged
dmcgowan merged 2 commits intoopencontainers:masterfrom Mar 5, 2021
Merged
Describe single-request monolithic upload behavior#239dmcgowan merged 2 commits intoopencontainers:masterfrom
dmcgowan merged 2 commits intoopencontainers:masterfrom
Conversation
Signed-off-by: Jon Johnson <[email protected]>
Signed-off-by: Jon Johnson <[email protected]>
Contributor
Author
|
@dmcgowan @jdolitsky PTAL |
Contributor
|
so we will leave conformance test then, for now? |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses the uncontroversial part of #234 by describing how clients should interpret the response codes from registries who do not support single request monolithic uploads.
I am happy to follow up with a deprecation doc, but the existing language from #221 is actually pretty reasonable and expresses some of what I had intended to convey by deprecating this.
The PR diff is not great because I flipped the order in which monolithic blob uploads are introduced, but I've split that into a separate commit to make it easier to review.