Conversation
|
@ashokponkumar was this required for you to use some of the Go libs in this repo? |
Not for this repo specifically. I am using the runtime-spec in https://github.ibm.com/app-modernization/move2kube/blob/master/go.mod and I noticed that some of the other spec's were missing the go.mod and that it might create a problem once we hit v2, hence added them and raised the pull request. |
| @@ -0,0 +1,3 @@ | |||
| module github.com/opencontainers/distribution-spec | |||
There was a problem hiding this comment.
Should this be based off go mod init specs-go/specs As there are no go files in the root or packages..
resulting in module specs-go/specs
There was a problem hiding this comment.
have you tested it over in another repo? I didn't try this out..
There was a problem hiding this comment.
We can evolve it similar to opencontainers/runtime-spec#1069
|
Thanks @mikebrow for the comments. @thaJeztah has created a proposal for a similar PR in runtime-spec in opencontainers/runtime-spec#1069. Based on how that proposal evolves, I can appropriately make the changes here. |
Signed-off-by: Ashok Pon Kumar <[email protected]>
ashokponkumar
force-pushed
the
addgomod
branch
from
dada738 to
6fd3e58
Compare
|
Is this still needed? |
|
I think this is still desirable, but some discussion needed on the approach (
|
|
maybe better if someone carries this and put's the go.mod in the right place |
|
closing in favor of #283 |
5 participants
Signed-off-by: Ashok Pon Kumar [email protected]