Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: opencontainers/cgroups
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.0.5
Choose a base ref
...
head repository: opencontainers/cgroups
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.0.6
Choose a head ref
  • 9 commits
  • 15 files changed
  • 6 contributors

Commits on Oct 25, 2025

  1. config: switch PidsLimit to *int64

    Previously we would treat a value of "0" as meaning "no-op", which lead
    to quite a bit of confusion. The runtime-spec has been updated to make
    the "pids.limit" value a pointer, and explicitly state that:
    
     * Values >= 0 should be treated as normal values; and
     * < 0 (usually -1) indicates "max".
    
    In practice this means we should switch PidsLimit to an *int64. Luckily,
    this is actually backwards-compatible with our previous JSON -- an old
    value of "0" would be omitted from the output, which will now be parsed
    as "nil". The handling by our cgroup code would be identical but the
    latter now correctly reflects the guidance by the runtime-spec.
    
    Signed-off-by: Aleksa Sarai <[email protected]>
    cyphar committed Oct 25, 2025
    9 Configuration menu
    Copy the full SHA
    ae52e0c View commit details
    Browse the repository at this point in the history
  2. systemd: add TasksMax test

    Co-developed-by: Kir Kolyshkin <[email protected]>
    Signed-off-by: Kir Kolyshkin <[email protected]>
    Signed-off-by: Aleksa Sarai <[email protected]>
    cyphar committed Oct 25, 2025
    Configuration menu
    Copy the full SHA
    7c34f09 View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2025

  1. Merge pull request #48 from cyphar/pids-limit-0

    config: switch PidsLimit to *int64
    AkihiroSuda authored Oct 28, 2025
    Configuration menu
    Copy the full SHA
    2f41057 View commit details
    Browse the repository at this point in the history
  2. systemd: retry when the dbus connection returns EAGAIN

    Signed-off-by: jianghao65536 <[email protected]>
    [cyphar: gofumpt systemd/dbus_test.go]
    [cyphar: simplify retry loop to return from inside loop]
    [cyphar: improve exponential backoff to be less aggressive]
    [cyphar: improve parallel test]
    Signed-off-by: Aleksa Sarai <[email protected]>
    jianghao65536 authored and cyphar committed Oct 28, 2025
    Configuration menu
    Copy the full SHA
    cd71e92 View commit details
    Browse the repository at this point in the history

Commits on Oct 29, 2025

  1. fs2: add iocost statistics

    When the iocost controller is enabled it will emit statistics about its
    usage in io.stat. Export this when available. This is a no-op when
    iocost is not enabled.
    
    There is a comment that we only expose data which directly maps to
    cgroups v1. We're already breaking this by adding PSI metrics, so reword
    this to just indicate that we currently don't recognize the other
    fields.
    
    Signed-off-by: Morten Hein Tiljeset <[email protected]>
    tiljeset committed Oct 29, 2025
    Configuration menu
    Copy the full SHA
    e313314 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #43 from tiljeset/iocost

    fs2: add iocost statistics
    kolyshkin authored Oct 29, 2025
    Configuration menu
    Copy the full SHA
    7305075 View commit details
    Browse the repository at this point in the history
  3. Merge pull request #45 from jianghao65536/eagain-retry

    systemd: retry when the dbus connection returns EAGAIN
    kolyshkin authored Oct 29, 2025
    Configuration menu
    Copy the full SHA
    c63eee3 View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2025

  1. fs: improve cpuacct.usage_all parsing

    First, we can reasonably expect the first three fields of
    cpuacct.usage_all to be "cpu user system", even for future kernels,
    and if we see something different, it doesn't make sense to continue.
    So check that the header is as expected, and error out otherwise.
    
    Second, if we have more than 3 values, and we've checked that the first
    3 are as expected ("cpu user system"), we can safely ignore extra
    columns. This fixes an issue on a custom kernel from Tencent, which
    adds a few extra columns (see [1]), as reported in issue 46.
    
    Add tests for both cases.
    
    Fixes issue 46.
    
    [1]: OpenCloudOS/TencentOS-kernel-0@0b66781
    Reported-by: vimiix <[email protected]>
    Signed-off-by: Kir Kolyshkin <[email protected]>
    lifubang authored and kolyshkin committed Oct 30, 2025
    Configuration menu
    Copy the full SHA
    5777053 View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2025

  1. Merge pull request #50 from kolyshkin/fix-usage-all

    fs: fix/improve cpuacct.usage_all parsing
    AkihiroSuda authored Oct 31, 2025
    Configuration menu
    Copy the full SHA
    e0c56cb View commit details
    Browse the repository at this point in the history
Loading