Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: opencontainers/cgroups
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.0.2
Choose a base ref
...
head repository: opencontainers/cgroups
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.0.3
Choose a head ref
  • 9 commits
  • 6 files changed
  • 3 contributors

Commits on Jun 11, 2025

  1. ConvertCPUSharesToCgroupV2Value: improve

    The old formula, while correctly converting the cgroup v1 range to
    cgroup v2 range, had a few issues:
    
    1. When cgroup v1 value is out of range, it returned invalid cgroup v2
       value, leading to vague errors down the line (see [1]).
    2. Default value cgroup v1 shares of 1024 is converted to 39, which is
       much less than the cgroup v2 default weight of 100 (see [2], [3]).
    
    The new conversion formula fixes both issues (see discussion in [2] for
    more details).
    
    Amend the test case accordingly.
    
    [1]: opencontainers/runc#4755
    [2]: kubernetes/kubernetes#131216
    [3]: opencontainers/runc#4772
    
    Signed-off-by: Kir Kolyshkin <[email protected]>
    kolyshkin committed Jun 11, 2025
    Configuration menu
    Copy the full SHA
    fd95216 View commit details
    Browse the repository at this point in the history
  2. TestConvertCPUSharesToCgroupV2Value: nits

    Rename some variables, and simplify the error message using
    the got/want pattern.
    
    Signed-off-by: Kir Kolyshkin <[email protected]>
    kolyshkin committed Jun 11, 2025
    Configuration menu
    Copy the full SHA
    75f91bd View commit details
    Browse the repository at this point in the history
  3. Merge pull request #20 from kolyshkin/cpu-shares-2

    ConvertCPUSharesToCgroupV2Value: improve
    thaJeztah authored Jun 11, 2025
    Configuration menu
    Copy the full SHA
    33e090f View commit details
    Browse the repository at this point in the history

Commits on Jun 12, 2025

  1. Add .github/dependabot.yml

    Make sure our github actions stay up to date.
    
    Since this is a package (set of packages), we do not to bump
    dependencies to the latest versions automatically, but only
    when it is really required, thus sticking to Go's minimum version
    selection rules (essentially so that users of these packages
    are not required to unnecessarily update their dependencies).
    
    Signed-off-by: Kir Kolyshkin <[email protected]>
    kolyshkin committed Jun 12, 2025
    Configuration menu
    Copy the full SHA
    534d09b View commit details
    Browse the repository at this point in the history
  2. ci/gha: add govulncheck job

    This is to ensure our minimal dependencies do not have known
    vulnerabilities.
    
    NOTE we do not specify Go version to be used here to avoid reporting
    vulnerabilities in stdlib which we're not interested in here.
    
    Signed-off-by: Kir Kolyshkin <[email protected]>
    kolyshkin committed Jun 12, 2025
    Configuration menu
    Copy the full SHA
    c801239 View commit details
    Browse the repository at this point in the history
  3. ci/gha: run all github CI once a week on main

    This is to ensure our CI is not rotting away when there are no new PRs
    or merges.
    
    Signed-off-by: Kir Kolyshkin <[email protected]>
    kolyshkin committed Jun 12, 2025
    Configuration menu
    Copy the full SHA
    d7edb92 View commit details
    Browse the repository at this point in the history
  4. Merge pull request #15 from kolyshkin/dep

    Add .github/dependabot.yml
    AkihiroSuda authored Jun 12, 2025
    Configuration menu
    Copy the full SHA
    fc3510e View commit details
    Browse the repository at this point in the history

Commits on Jun 18, 2025

  1. Remove annotations from Resources

    This results in different JSON than the older version:
    
    Before commit fd4995c:
    
        "cgroups": {
          ...
          "devices": [
            ...
    
    After:
    
        "cgroups": {
          ...
          "Resources": {
            "devices": [
    
    This breaks backward compatibility for runc.
    
    Fixes: fd4995c ("Add omitempty JSON attribute for some fields")
    Signed-off-by: Kir Kolyshkin <[email protected]>
    kolyshkin committed Jun 18, 2025
    Configuration menu
    Copy the full SHA
    7e58331 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #22 from kolyshkin/resources-fixup

    Remove annotations from Resources
    thaJeztah authored Jun 18, 2025
    Configuration menu
    Copy the full SHA
    b970779 View commit details
    Browse the repository at this point in the history
Loading