-
Notifications
You must be signed in to change notification settings - Fork 25
Comparing changes
Open a pull request
base repository: opencontainers/cgroups
base: v0.0.2
head repository: opencontainers/cgroups
compare: v0.0.3
- 9 commits
- 6 files changed
- 3 contributors
Commits on Jun 11, 2025
-
ConvertCPUSharesToCgroupV2Value: improve
The old formula, while correctly converting the cgroup v1 range to cgroup v2 range, had a few issues: 1. When cgroup v1 value is out of range, it returned invalid cgroup v2 value, leading to vague errors down the line (see [1]). 2. Default value cgroup v1 shares of 1024 is converted to 39, which is much less than the cgroup v2 default weight of 100 (see [2], [3]). The new conversion formula fixes both issues (see discussion in [2] for more details). Amend the test case accordingly. [1]: opencontainers/runc#4755 [2]: kubernetes/kubernetes#131216 [3]: opencontainers/runc#4772 Signed-off-by: Kir Kolyshkin <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for fd95216 - Browse repository at this point
Copy the full SHA fd95216View commit details -
TestConvertCPUSharesToCgroupV2Value: nits
Rename some variables, and simplify the error message using the got/want pattern. Signed-off-by: Kir Kolyshkin <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 75f91bd - Browse repository at this point
Copy the full SHA 75f91bdView commit details -
Merge pull request #20 from kolyshkin/cpu-shares-2
ConvertCPUSharesToCgroupV2Value: improve
Configuration menu - View commit details
-
Copy full SHA for 33e090f - Browse repository at this point
Copy the full SHA 33e090fView commit details
Commits on Jun 12, 2025
-
Make sure our github actions stay up to date. Since this is a package (set of packages), we do not to bump dependencies to the latest versions automatically, but only when it is really required, thus sticking to Go's minimum version selection rules (essentially so that users of these packages are not required to unnecessarily update their dependencies). Signed-off-by: Kir Kolyshkin <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 534d09b - Browse repository at this point
Copy the full SHA 534d09bView commit details -
This is to ensure our minimal dependencies do not have known vulnerabilities. NOTE we do not specify Go version to be used here to avoid reporting vulnerabilities in stdlib which we're not interested in here. Signed-off-by: Kir Kolyshkin <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for c801239 - Browse repository at this point
Copy the full SHA c801239View commit details -
ci/gha: run all github CI once a week on main
This is to ensure our CI is not rotting away when there are no new PRs or merges. Signed-off-by: Kir Kolyshkin <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for d7edb92 - Browse repository at this point
Copy the full SHA d7edb92View commit details -
Merge pull request #15 from kolyshkin/dep
Add .github/dependabot.yml
Configuration menu - View commit details
-
Copy full SHA for fc3510e - Browse repository at this point
Copy the full SHA fc3510eView commit details
Commits on Jun 18, 2025
-
Remove annotations from Resources
This results in different JSON than the older version: Before commit fd4995c: "cgroups": { ... "devices": [ ... After: "cgroups": { ... "Resources": { "devices": [ This breaks backward compatibility for runc. Fixes: fd4995c ("Add omitempty JSON attribute for some fields") Signed-off-by: Kir Kolyshkin <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 7e58331 - Browse repository at this point
Copy the full SHA 7e58331View commit details -
Merge pull request #22 from kolyshkin/resources-fixup
Remove annotations from Resources
Configuration menu - View commit details
-
Copy full SHA for b970779 - Browse repository at this point
Copy the full SHA b970779View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v0.0.2...v0.0.3