Repository navigation
Roll back to npm 11 - #12120
Roll back to npm 11#12120
Conversation
This reverts commit e4dc077.
No Node release bundles npm 12 (nodejs/node#64882 was closed), so a 12.x engine pin forces every environment to install npm on top of Node for the life of the LTS. Stay on the bundled major and stop Renovate from proposing the next one.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (6)
💤 Files with no reviewable changes (3)
Included review availability: Your plan provides up to 2 included reviews per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe change standardizes the repository on npm 11.x. CI and end-to-end workflows no longer install npm 12 and instead use the npm version supplied by Node.js setup. Renovate ignores major npm engine updates. Commitizen configuration moves into
Priority: ➖ Normal Estimated code review effort: 2 (Simple) | ~10 minutes Suggested reviewers: Merge Risk: ⚪ Minimal · up to The npm 11 rollback and Commitizen migration preserve clean installs, CI behavior, and commit tooling, so the change is ready to merge. 🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 06c6bb2b2d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| - name: Enable npm 12 | ||
| run: npm install -g [email protected] | ||
|
|
||
| # Checkouts |
There was a problem hiding this comment.
When the images dependency cache misses, this workflow checks out opencollective-images at its current default branch and runs its npm ci with the stock npm 11 selected here. As the commit description notes, images PR #687 has already moved that repository to npm 12 and its npm-11 rollback still needs to follow, so its engine-strict install exits with EBADENGINE; npm documents that engines becomes enforceable when engine-strict is enabled. Keep a per-checkout npm 12 setup or land the images rollback before deleting this step, otherwise the API E2E job only succeeds while the images node_modules cache hits.
Useful? React with 👍 / 👎.
Reverts #12073 and pins npm to the major bundled with Node.
No Node release ships npm 12: Node 24.21 (our LTS line) and Node 26.9 both bundle npm 11, and the Node PR to bundle npm 12 (nodejs/node#64882) was closed unmerged in August. Requiring
12.xtherefore means every environment (CI, Heroku, Docker, and every other repo that installs this one in its workflows) has to install npm on top of Node for the life of the LTS. Today that broke the frontend E2E job and the images CI, which install this repo with the stock npm, and the API's own E2E only passed onnode_modulescache hits.engines.npmback to11.x,packageManagerfield removed,Enable npm 12steps removed fromci.ymlande2e.yml, README back to 11.x. The commitizen config returns topackage.json(the.czrcmove was only needed for npm 12).renovate.json: disable major updates of thenpmengine so Renovate does not re-propose 12.Verified with the stock npm 11.12.1:
npm ciinstalls 1488 packages, noEBADENGINE, noEUNKNOWNCONFIG.Supersedes #12119. opencollective/opencollective-images#687 (merged) and opencollective/opencollective-frontend#12401 (open) were both driven by #12073 and need to follow: images back to accepting npm 11, and the frontend PR closed.
Related to opencollective/opencollective#8984