Skip to content

Develop algorithms for gene deletion strategies for growth-coupled production#2427

Merged
rmtfleming merged 5 commits intoopencobra:developfrom
MetNetComp:develop
May 8, 2025
Merged

Develop algorithms for gene deletion strategies for growth-coupled production#2427
rmtfleming merged 5 commits intoopencobra:developfrom
MetNetComp:develop

Conversation

@MetNetComp
Copy link
Copy Markdown
Contributor

@MetNetComp MetNetComp commented Feb 10, 2025

Dear Administrator,

TrimGdel appropriately considers GPR rules and derives the minimal and maximal gene deletion strategies for growth-coupled production.

T. Tamura, "Trimming Gene Deletion Strategies for Growth-Coupled Production in Constraint-Based Metabolic Networks: TrimGdel," in IEEE/ACM Transactions on Computational Biology and Bioinformatics, vol. 20, no. 2, pp. 1540-1549, 2023.

Best regards,
Takeyuki Tamura,
Kyoto University, Japan.

  • Tested my code on my own machine
  • Followed the guidelines in the Contributing Guide
  • Selected develop as a target branch (top left drop-down menu)

(Note: You may replace [ ] with [X] to check the box)

@farid-zare farid-zare closed this Feb 18, 2025
@farid-zare farid-zare reopened this Feb 18, 2025
@github-actions
Copy link
Copy Markdown
Contributor

Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️
235 188 0 47

No failed tests ✨

Github Test Reporter by CTRF 💚

Copy link
Copy Markdown
Member

@rmtfleming rmtfleming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove src/design/TrimGdel/e_coli_core.mat because that is in COBRA.models

Also ALL functions should have complete headers. See printFunctionIO

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 7, 2025

Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️
236 189 0 47

No failed tests ✨

Github Test Reporter by CTRF 💚

@MetNetComp
Copy link
Copy Markdown
Contributor Author

MetNetComp commented Mar 7, 2025

Dear Ronan

Thank you for your review.
I removed e_coli_core.mat; added complete headers to all functions;
added the test function to /test/verifiedTests/.

Also, I made a pull request for ~/COBRA.tutorials and ~/COBRA.models/mat/.

Best regards,
Takeyuki

@MetNetComp
Copy link
Copy Markdown
Contributor Author

I would appreciate it if you could let me know of any additional points that need modification.

Comment thread src/design/TrimGdel/testTrimGdel.m Outdated
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,
As you have already added this test function in the test folder, I believe you could please remove it from the src code folder.
Thanks

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I have removed src/design/TrimGdel/testTrimGdel.m.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 9, 2025

Summary:

Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️
238 191 0 47

Failed Tests:

No failed tests ✨

Github Test Reporter by CTRF 💚

@rmtfleming rmtfleming merged commit 7340dad into opencobra:develop May 8, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants