Skip to content

Addfile icongems#2271

Merged
rmtfleming merged 7 commits intoopencobra:masterfrom
ThummaratPaklao:addfile_icongems
Aug 28, 2024
Merged

Addfile icongems#2271
rmtfleming merged 7 commits intoopencobra:masterfrom
ThummaratPaklao:addfile_icongems

Conversation

@ThummaratPaklao
Copy link
Copy Markdown
Contributor

Please include a short description of enhancement here

  • Add file src/analysis/ICON-GEMs/ICON-GEMs.m
  • Add file test/additionalTests/testICONGEMs/testICONGEMs.m

@farid-zare
Copy link
Copy Markdown
Collaborator

Hi Thummarat,
Thanks for your contribution.
Could you please avoid using signs to name repositories and functions? e.g. minus sign in "ICON-GEMs"

@ThummaratPaklao
Copy link
Copy Markdown
Contributor Author

Hi Farid-Zare,

Thank you for your feedback! I understand the concern about using signs like the minus sign in repository and function names, as it can lead to issues in some environments.

I renamed ICON-GEMs to remove the minus sign, and I also updated any related function names to follow a more compatible naming convention.

Thanks again for helping improve the project!

@rmtfleming rmtfleming merged commit d906aa3 into opencobra:master Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants