Skip to content

Remove backtest - #555

Merged
lm2612 merged 4 commits into
mainfrom
remove-backtest
Oct 30, 2026
Merged

lm2612 merged 4 commits into
mainfrom
remove-backtest

Conversation

@lm2612

@lm2612 lm2612 commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

Pull Request

Description

Remove backtest and scorecard from scripts/. These now live in https://github.com/openclimatefix/ml-tooling/tree/main/backtests. Also removed backtest section from the README (this also contained out of date links to backtest scripts)
Fixes #553

How Has This Been Tested?

Should not affect pvnet training.

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

@lm2612
lm2612 marked this pull request as ready for review October 28, 2026 11:42
@AUdaltsova

AUdaltsova commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

I wonder if it's worth updating the readme section instead of deleting it? We do let the pvnet readme go woefully out of date from time to time, but I think this is still our main bit of docs on how to use it, and I think it's nice to have the backtest instructions in there, even if they just point to ml-tooling.

@Sukh-P Sukh-P left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for cleaning this up!

@lm2612

lm2612 commented Oct 28, 2026

Copy link
Copy Markdown
Contributor Author

I wonder if it's worth updating the readme section instead of deleting it? We do let the pvnet readme go woefully out of date from time to time, but I think this is still our main bit of docs on how to use it, and I think it's nice to have the backtest instructions in there, even if they just point to ml-tooling.

Thanks for pointing this out Alex. Two things - as you say there are some out of date things in the readme like the streamed samples. I might make a new issue to update this. But for the backtest, happy to put back in the instructions on how find and run the backtest, but just wondering on what you both think about the fact that ml-tooling is a private ocf repo? So this would only be useful to internal ocf team

@AUdaltsova

Copy link
Copy Markdown
Contributor

Thanks for pointing this out Alex. Two things - as you say there are some out of date things in the readme like the streamed samples. I might make a new issue to update this. But for the backtest, happy to put back in the instructions on how find and run the backtest, but just wondering on what you both think about the fact that ml-tooling is a private ocf repo? So this would only be useful to internal ocf team

Yeah that's fair, I don't think we get much open-source traffic on pvnet though & I do think it would be useful to link to this, so maybe just specify that this is for internal use? And yeah, agree that the readme needs a spruce in a separate issue!

@lm2612
lm2612 merged commit f7382cc into main Oct 30, 2026
1 check passed
@lm2612
lm2612 deleted the remove-backtest branch October 30, 2026 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove backtest and scorecard

3 participants