Repository navigation
Remove backtest - #555
Remove backtest#555
Conversation
|
I wonder if it's worth updating the readme section instead of deleting it? We do let the pvnet readme go woefully out of date from time to time, but I think this is still our main bit of docs on how to use it, and I think it's nice to have the backtest instructions in there, even if they just point to ml-tooling. |
Sukh-P
left a comment
There was a problem hiding this comment.
Nice, thanks for cleaning this up!
Thanks for pointing this out Alex. Two things - as you say there are some out of date things in the readme like the streamed samples. I might make a new issue to update this. But for the backtest, happy to put back in the instructions on how find and run the backtest, but just wondering on what you both think about the fact that ml-tooling is a private ocf repo? So this would only be useful to internal ocf team |
Yeah that's fair, I don't think we get much open-source traffic on pvnet though & I do think it would be useful to link to this, so maybe just specify that this is for internal use? And yeah, agree that the readme needs a spruce in a separate issue! |
Pull Request
Description
Remove backtest and scorecard from
scripts/. These now live in https://github.com/openclimatefix/ml-tooling/tree/main/backtests. Also removed backtest section from the README (this also contained out of date links to backtest scripts)Fixes #553
How Has This Been Tested?
Should not affect pvnet training.
Checklist: