fix: default TLS gateway deep links to port 443 when port is omitted by ly85206559 · Pull Request #99887 · openclaw/openclaw

ly85206559 · 2026-07-04T08:19:00Z

What Problem This Solves

Fixes two coupled iOS gateway setup failures:

A gateway deep link with TLS enabled and no explicit port parsed to port 18789 instead of the standard TLS port 443.
Any mounted Settings view could consume the pending setup request before the routed, canonical Settings screen appeared.

Setup codes and raw gateway URL parsing in OpenClawKit already default omitted TLS/WSS ports to 443; the openclaw://gateway query parser did not.

Why This Change Was Made

Centralize the TLS default-port rule in DeepLinks.swift (tls ? 443 : 18789) and use it for setup payloads, raw URLs, and gateway deep links.

Make gateway setup request ownership explicit: RootTabs consumes the model's one-shot link, selects the gateway route, and passes one typed request only to the canonical phone or iPad Settings surface. Settings acknowledges the request after staging it, preventing both hidden-view consumption and replay after navigation.

The change preserves explicit ports, so existing links such as openclaw://gateway?...&port=18789&tls=1 still parse to 18789.

User Impact

TLS gateway deep links from QR codes or shared links now stage the expected HTTPS/WSS endpoint without requiring an explicit port=443 parameter. This works on both phone and iPad layouts even when another Settings surface is already mounted. Explicit ports remain unchanged, and omitted plaintext ports still default to 18789.

Evidence

Parser regression proof:

swift test --package-path apps/shared/OpenClawKit --filter DeepLinksSecurityTests
21 tests passed, covering omitted TLS and plaintext ports plus explicit TLS ports.

Build proof:

Fresh generated iOS project, Debug simulator build: ** BUILD SUCCEEDED **
SwiftFormat and SwiftLint build phases passed.
Native app localization inventory regenerated and native-app-i18n.ts check passes.

Live end-to-end proof using the exact built app:

iPhone 17 simulator: opened and applied two consecutive unique TLS links without ports. Each Connect replaced the previous host and applied port 443 with TLS.
iPad Pro 13-inch simulator: repeated the same two-link matrix in canonical sidebar Settings. The second request replaced the first and retained port 443 with TLS.

Review and related-work check:

Fresh exact-head autoreview: no findings, confidence 0.90.
No exact duplicate found. feat(ios): redeem gateway setup short codes #98265 (setup short codes) and fix(ios): focus missing gateway credentials #98189 (onboarding tests) are related but non-overlapping.
No UI layout or styling change, so there is no meaningful before/after visual delta.

clawsweeper · 2026-07-04T08:20:22Z

Codex review: needs maintainer review before merge. Reviewed July 5, 2026, 8:28 AM ET / 12:28 UTC.

Summary
This PR changes OpenClawKit gateway deep-link parsing to default omitted TLS ports to 443, routes iOS gateway setup requests through RootTabs to Settings, updates tests, removes a dead terminal helper, and refreshes native i18n inventory.

PR surface: Other +56. Total +56 across 7 files.

Reproducibility: yes. from source inspection: current main hard-codes omitted openclaw://gateway ports to 18789 before considering tls, while setup-code and raw WSS/HTTPS inputs already default omitted TLS ports to 443. I did not run the simulator in this read-only review.

Review metrics: 1 noteworthy metric.

Gateway deep-link defaults: 1 changed default. The PR changes the omitted-port default for tls=1 gateway deep links, which is compatibility-relevant before merge.

Merge readiness
Overall: 🐚 platinum hermit
Proof: 🐚 platinum hermit
Patch quality: 🐚 platinum hermit
Result: ready for maintainer review.

Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch.

Rank-up moves:

[P2] Let exact-head CI finish green or repair any diff-caused failing lane before merge.

Risk before merge

[P1] Merging changes existing omitted-port tls=1 iOS gateway deep links from port 18789 to 443 unless those links include an explicit port.
[P1] Exact-head CI was still in progress during inspection, so normal merge readiness still depends on the required checks finishing green.

Maintainer options:

Accept corrected TLS default (recommended)
Merge after CI if maintainers are comfortable that omitted tls=1 links now resolve to 443 and non-443 TLS deployments must specify port.
Add compatibility wording
Require PR-body or release-note context that calls out explicit port for non-443 TLS gateway links before merge.
Pause if legacy behavior is required
Keep the PR paused if omitted-port TLS links must continue targeting 18789 by default.

Next step before merge

[P2] Maintainers should decide the omitted TLS port compatibility change and wait for exact-head CI; there is no narrow automated repair to queue.

Maintainer decision needed

Question: Should omitted tls=1 iOS gateway deep links intentionally switch from the old 18789 fallback to the standard TLS port 443 while preserving explicit port values?
Rationale: The code path is a valid bug fix against existing setup-code and raw WSS defaults, but it changes behavior for any existing non-443 TLS deployment that omitted port.
Likely owner: steipete — steipete is assigned and has both recent branch and current-main ownership signals for the affected iOS setup path.
Options:
- Accept the corrected TLS default (recommended): Merge after CI with the expectation that non-443 TLS gateway links must include an explicit port.
- Require compatibility wording first: Ask for PR-body or release-note wording that tells users with non-443 TLS gateways to include port in deep links before merge.
- Keep the legacy fallback: Reject this default change and require another product path for omitted-port TLS deep links.

Security
Cleared: The diff changes iOS deep-link parsing and in-memory setup-request delivery without adding dependencies, workflows, secret storage, downloaded code, or a broader plaintext transport allowance.

Review details

Best possible solution:

Land this focused fix or an equivalent one after maintainers accept the omitted-TLS-port compatibility change and exact-head CI is green.

Do we have a high-confidence way to reproduce the issue?

Yes, from source inspection: current main hard-codes omitted openclaw://gateway ports to 18789 before considering tls, while setup-code and raw WSS/HTTPS inputs already default omitted TLS ports to 443. I did not run the simulator in this read-only review.

Is this the best way to solve the issue?

Yes, this is the best fix shape: centralizing the TLS default in OpenClawKit removes parser drift, and RootTabs is the right owner for one-shot setup delivery to the canonical Settings surface. The only safer addition would be maintainer-approved compatibility wording for non-443 TLS links.

AGENTS.md: found and applied where relevant.

Codex review notes: model internal, reasoning high; reviewed against fd2e4da00651.

Label changes

Label justifications:

P2: This is a normal-priority iOS setup correctness fix with limited blast radius around gateway pairing and deep links.
merge-risk: 🚨 compatibility: Merging changes existing omitted-port tls=1 gateway deep links from 18789 to 443 unless the link includes an explicit port.
rating: 🐚 platinum hermit: Overall readiness is 🐚 platinum hermit; proof is 🐚 platinum hermit and patch quality is 🐚 platinum hermit.
status: 👀 ready for maintainer look: ClawSweeper has no concrete contributor-facing blocker left for this PR. Sufficient (live_output): The PR body reports exact-head parser tests, a Debug simulator build, native i18n verification, and live iPhone/iPad simulator runs showing TLS links without ports applying port 443.
proof: sufficient: Contributor real behavior proof is sufficient. The PR body reports exact-head parser tests, a Debug simulator build, native i18n verification, and live iPhone/iPad simulator runs showing TLS links without ports applying port 443.

Evidence reviewed

PR surface:

Other +56. Total +56 across 7 files.

View PR surface stats

Area	Files	Added	Removed	Net
Source	0	0	0	0
Tests	0	0	0	0
Docs	0	0	0	0
Config	0	0	0	0
Generated	0	0	0	0
Other	7	131	75	+56
Total	7	131	75	+56

What I checked:

Current main parser bug: Current main already defaults setup-code host payloads and raw WSS/HTTPS gateway URLs without a port to 443, but openclaw://gateway query parsing still defaults an omitted port to 18789 before considering tls. (apps/shared/OpenClawKit/Sources/OpenClawKit/DeepLinks.swift:256, fd2e4da00651)
PR parser fix: The PR adds one defaultGatewayPort(tls:) helper and uses it for setup payloads, raw URLs, and openclaw://gateway query parsing, preserving explicit ports. (apps/shared/OpenClawKit/Sources/OpenClawKit/DeepLinks.swift:261, a56254d1d183)
Focused regression coverage: The PR adds tests for omitted TLS ports, omitted plaintext ports, and explicit TLS ports in gateway deep-link parsing. (apps/shared/OpenClawKit/Tests/OpenClawKitTests/DeepLinksSecurityTests.swift:31, a56254d1d183)
Current main setup-consumption risk: Current main lets each mounted SettingsProTab observe gatewaySetupRequestID and consume NodeAppModel's one-shot pending setup link, matching the hidden Settings consumption failure described in the PR body. (apps/ios/Sources/Design/SettingsProTab.swift:175, fd2e4da00651)
PR setup-delivery ownership: The PR moves consumption into RootTabs, stores one typed GatewaySetupRequest, passes it to the routed Settings surface, and clears it after Settings handles the request. (apps/ios/Sources/RootTabs.swift:1300, a56254d1d183)
Related batch is only partial overlap: The related batch PR includes the TLS parser default change but not the RootTabs/Settings setup-delivery fix, so it does not fully supersede this PR. (12b08861bf38)

Likely related people:

steipete: steipete is assigned, authored the latest branch commits, and recent current-main history touches both iOS RootTabs and shared DeepLinks behavior. (role: recent area contributor and likely follow-up owner; confidence: high; commits: a56254d1d183, c64a306f908b, 211e0d7263c1; files: apps/ios/Sources/RootTabs.swift, apps/ios/Sources/Design/SettingsProTab.swift, apps/shared/OpenClawKit/Sources/OpenClawKit/DeepLinks.swift)
mbelinky: GitHub commit metadata links mbelinky to the original iOS QR pairing flow and insecure gateway deep-link hardening history that established this parser surface. (role: earlier iOS pairing and deep-link contributor; confidence: medium; commits: 130e59a9c096, ebae6f918e18; files: apps/shared/OpenClawKit/Sources/OpenClawKit/DeepLinks.swift, apps/shared/OpenClawKit/Tests/OpenClawKitTests/DeepLinksSecurityTests.swift)
BunsDev: Recent path history shows BunsDev working on iOS LAN pairing and gateway setup hardening in the same OpenClawKit deep-link area. (role: gateway pairing hardening contributor; confidence: medium; commits: 36df0d93b93a, b2efd1964800; files: apps/shared/OpenClawKit/Sources/OpenClawKit/DeepLinks.swift, apps/shared/OpenClawKit/Tests/OpenClawKitTests/DeepLinksSecurityTests.swift)

What the crustacean ranks mean

🦀 challenger crab: rare, exceptional readiness with strong proof, clean implementation, and convincing validation.
🦞 diamond lobster: very strong readiness with only minor maintainer review expected.
🐚 platinum hermit: good normal PR, likely mergeable with ordinary maintainer review.
🦐 gold shrimp: useful signal, but proof or patch confidence is still limited.
🦪 silver shellfish: thin signal; proof, validation, or implementation needs work.
🧂 unranked krab: not merge-ready because proof is missing/unusable or there are serious correctness or safety concerns.
🌊 off-meta tidepool: rating does not apply to this item.

Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics.

How this review workflow works

ClawSweeper keeps one durable marker-backed review comment per issue or PR.
Re-runs edit this comment so the latest verdict, findings, and automation markers stay together instead of adding duplicate bot comments.
A fresh review can be triggered by eligible @clawsweeper re-review comments, exact-item GitHub events, scheduled/background review runs, or manual workflow dispatch.
PR/issue authors and users with repository write access can comment @clawsweeper re-review or @clawsweeper re-run on an open PR or issue to request a fresh review only.
Maintainers can also comment @clawsweeper review to request a fresh review only.
Fresh-review commands do not start repair, autofix, rebase, CI repair, or automerge.
Maintainer-only repair and merge flows require explicit commands such as @clawsweeper autofix, @clawsweeper automerge, @clawsweeper fix ci, or @clawsweeper address review.
Maintainers can comment @clawsweeper explain to ask for more context, or @clawsweeper stop to stop active automation.

Review history (7 earlier review cycles)

reviewed 2026-07-04T08:23:28.415Z sha 9e73a8a :: needs real behavior proof before merge. :: none
reviewed 2026-07-04T08:29:33.384Z sha 9e73a8a :: needs real behavior proof before merge. :: none
reviewed 2026-07-04T08:46:52.829Z sha 9e73a8a :: needs real behavior proof before merge. :: none
reviewed 2026-07-04T08:55:08.829Z sha 9e73a8a :: needs real behavior proof before merge. :: none
reviewed 2026-07-05T09:42:40.598Z sha 41c653a :: needs real behavior proof before merge. :: none
reviewed 2026-07-05T11:43:30.630Z sha 4e7921b :: needs maintainer review before merge. :: none
reviewed 2026-07-05T12:20:30.000Z sha ad20758 :: needs maintainer review before merge. :: none

Align openclaw://gateway parsing with setup-code and URL helpers so tls=1 without an explicit port uses 443 instead of 18789. Co-authored-by: Cursor <[email protected]>

steipete · 2026-07-05T12:34:02Z

Thank you for the contribution. This fix landed with contributor co-authorship preserved in #100258 (deac98eb7204fdb51589c5e369b95be128215e77).

I consolidated the source fixes into a maintainer takeover because the contributor branches were based on rewritten pre-main history; updating them directly would have pulled unrelated changes into the review surface. Closing this PR as superseded by the landed batch.

steipete · 2026-07-05T12:36:37Z

Land-ready validation for a56254d1d1836d37ef96c7af8acd5f5a131538e0:

swift test --package-path apps/shared/OpenClawKit --filter DeepLinksSecurityTests — 21/21 passed.
node --import tsx scripts/native-app-i18n.ts check — clean (2,493 entries, no drift).
Generated-project iOS Debug simulator build — BUILD SUCCEEDED; SwiftFormat and SwiftLint build phases passed.
iPhone 17 exact-app proof — applied two consecutive unique TLS gateway links without ports; each Connect replaced the prior host and applied port 443 with TLS.
iPad Pro 13-inch exact-app proof — repeated the same two-link matrix in canonical sidebar Settings; the second request replaced the first and retained port 443 with TLS.
Fresh Codex autoreview — no findings, patch correct (0.90 confidence).
Hosted CI: https://github.com/openclaw/openclaw/actions/runs/28740624930
iOS Periphery: https://github.com/openclaw/openclaw/actions/runs/28740624934

No screenshot was attached because this changes parsing and one-shot state ownership, not layout or styling; the meaningful before/after proof is the applied host/port/TLS state above.

openclaw-barnacle Bot added the size: XS label Jul 4, 2026

ly85206559 changed the title ~~OpenClawKit: default TLS gateway deep links to port 443~~ fix: TLS gateway deep links use port 18789 when port is omitted Jul 4, 2026

steipete self-assigned this Jul 4, 2026

ly85206559 changed the title ~~fix: TLS gateway deep links use port 18789 when port is omitted~~ fix: default TLS gateway deep links to port 443 when port is omitted Jul 4, 2026

ly85206559 force-pushed the fix/deeplink-tls-default-port branch from 9e73a8a to 41c653a Compare July 5, 2026 09:24

openclaw-barnacle Bot added triage: needs-pr-context Candidate: external PR body lacks required problem context or evidence. and removed triage: needs-pr-context Candidate: external PR body lacks required problem context or evidence. labels Jul 5, 2026

steipete mentioned this pull request Jul 5, 2026

fix: harden small runtime and installer edge cases #100258

Merged

steipete force-pushed the fix/deeplink-tls-default-port branch from 41c653a to ea70d70 Compare July 5, 2026 11:07

openclaw-barnacle Bot added app: ios App: ios size: S and removed size: XS labels Jul 5, 2026

steipete force-pushed the fix/deeplink-tls-default-port branch from 71bc183 to 4e7921b Compare July 5, 2026 11:35

steipete force-pushed the fix/deeplink-tls-default-port branch 2 times, most recently from 49b58d2 to 42367f0 Compare July 5, 2026 11:57

openclaw-barnacle Bot added size: M and removed size: S labels Jul 5, 2026

steipete force-pushed the fix/deeplink-tls-default-port branch from 65aa991 to ad20758 Compare July 5, 2026 12:13

clawsweeper Bot removed the proof: sufficient ClawSweeper judged the real behavior proof convincing. label Jul 5, 2026

ly85206559 and others added 9 commits July 5, 2026 13:22

OpenClawKit: default TLS gateway deep links to port 443

5915fa6

Align openclaw://gateway parsing with setup-code and URL helpers so tls=1 without an explicit port uses 443 instead of 18789. Co-authored-by: Cursor <[email protected]>

refactor(apple): centralize gateway deep link port defaults

890911c

test(apple): streamline gateway port cases

bcacf66

fix(ios): route gateway setup to canonical settings

2707dc5

chore(ios): sync native i18n inventory

b4cfe7e

refactor(ios): remove dead terminal identity overload

8e4cf3a

fix(ios): preserve gateway setup across sidebar routing

a28d902

refactor(ios): deliver gateway setup to canonical settings

5f4525b

fix(ios): own gateway setup delivery in root

a56254d

steipete force-pushed the fix/deeplink-tls-default-port branch from ad20758 to a56254d Compare July 5, 2026 12:22

steipete closed this Jul 5, 2026

ly85206559 deleted the fix/deeplink-tls-default-port branch July 5, 2026 12:42

steipete mentioned this pull request Jul 5, 2026

fix(ios): own gateway setup deep-link delivery #100328

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

fix: default TLS gateway deep links to port 443 when port is omitted#99887

fix: default TLS gateway deep links to port 443 when port is omitted#99887
ly85206559 wants to merge 9 commits into
openclaw:mainfrom
ly85206559:fix/deeplink-tls-default-port

ly85206559 commented Jul 4, 2026 •

edited by steipete

Loading

Uh oh!

clawsweeper Bot commented Jul 4, 2026 •

edited

Loading

Uh oh!

steipete commented Jul 5, 2026

Uh oh!

steipete commented Jul 5, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Uh oh!

Conversation

ly85206559 commented Jul 4, 2026 • edited by steipete Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What Problem This Solves

Why This Change Was Made

User Impact

Evidence

Uh oh!

clawsweeper Bot commented Jul 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

steipete commented Jul 5, 2026

Uh oh!

steipete commented Jul 5, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

ly85206559 commented Jul 4, 2026 •

edited by steipete

Loading

clawsweeper Bot commented Jul 4, 2026 •

edited

Loading