fix(providers): resolve ClawRouter auth-profile models#99759
Conversation
|
Codex review: needs real behavior proof before merge. Reviewed July 3, 2026, 10:10 PM ET / 02:10 UTC. Summary PR surface: Source +65, Tests +59, Docs +5. Total +129 across 4 files. Reproducibility: yes. from source, not from a live run: current main can discover ClawRouter models with an auth-profile credential, but runtime model resolution has no ClawRouter dynamic hook to refresh those catalog rows for an auth-profile-only setup. Review metrics: 1 noteworthy metric.
Stored data model Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Rank-up moves:
Proof guidance:
Risk before merge
Maintainer options:
Next step before merge
Security Review findings
Review detailsBest possible solution: Land the narrow ClawRouter plugin fix after removing the release-owned changelog entry and adding redacted real-run proof for auth-profile model resolution and fail-closed credential behavior. Do we have a high-confidence way to reproduce the issue? Yes from source, not from a live run: current main can discover ClawRouter models with an auth-profile credential, but runtime model resolution has no ClawRouter dynamic hook to refresh those catalog rows for an auth-profile-only setup. Is this the best way to solve the issue? Yes, with one cleanup: using provider-local prepareDynamicModel/resolveDynamicModel is the narrowest maintainable seam for this bug, but the release-owned CHANGELOG edit should be dropped. Full review comments:
Overall correctness: patch is correct AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against a1063aa4c83f. Label changesLabel changes:
Label justifications:
Evidence reviewedPR surface: Source +65, Tests +59, Docs +5. Total +129 across 4 files. View PR surface stats
What I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 791103dc74
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| ### Fixes | ||
|
|
||
| - **ClawRouter auth profiles:** resolve credential-scoped catalog models during agent runs when the proxy key is stored in an auth profile, and document plugin and model allowlists. |
There was a problem hiding this comment.
Remove the non-release changelog entry
Root AGENTS.md says CHANGELOG.md is release-only and release generation owns it, but this normal provider fix adds a new bullet to the already dated 2026.7.1 section. That makes the hand-edited release notes diverge from the generated release flow and can misattribute post-release fixes, so leave this out of CHANGELOG.md unless this is the release-generation commit.
Useful? React with 👍 / 👎.
Summary
Why
ClawRouter model listing could resolve a stored auth-profile credential, but agent runtime resolution only saw persisted provider models. A catalog model selected from
agents.defaults.modelstherefore failed as unknown unless the key was also present in the environment or the provider catalog had been written into config.Validation
pnpm exec vitest run extensions/clawrouter/index.test.ts extensions/clawrouter/provider-catalog.test.tspnpm tsgo:extensionspnpm tsgo:extensions:testpnpm docs:check-mdxpnpm format:docs:check