fix(qa): prevent smoke gateways from losing built files#99736
Conversation
|
@clawsweeper re-review |
|
🦞🧹 I asked ClawSweeper to review this item again. |
|
Codex review: needs maintainer review before merge. Reviewed July 3, 2026, 9:18 PM ET / 01:18 UTC. Summary PR surface: Source +19, Tests +72. Total +91 across 2 files. Reproducibility: yes. Current main includes the script-backed Docker scenario and still schedules test-file work alongside flow partitions, while the linked issue and Actions evidence show missing shared dist files under that mixed selection; I did not rerun the expensive smoke path locally. Review metrics: 1 noteworthy metric.
Root-cause cluster Members:
Proposal only: this assessment does not dispatch repair, suppress jobs, mutate sibling items, close, or merge anything. Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Rank-up moves:
Risk before merge
Maintainer options:
Next step before merge
Security Review detailsBest possible solution: Land the scheduler-level isolation after final PR or merge-result QA checks, keeping Docker lane behavior unchanged and preventing package-mutating scripts from overlapping flow Gateways. Do we have a high-confidence way to reproduce the issue? Yes. Current main includes the script-backed Docker scenario and still schedules test-file work alongside flow partitions, while the linked issue and Actions evidence show missing shared dist files under that mixed selection; I did not rerun the expensive smoke path locally. Is this the best way to solve the issue? Yes. The scheduler is the best layer because the failure comes from package-mutating script scenarios overlapping flow Gateway processes, not from a specific Docker lane implementation. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against ab9e233d02a8. Label changesLabel changes:
Label justifications:
Evidence reviewedPR surface: Source +19, Tests +72. Total +91 across 2 files. View PR surface stats
What I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
|
|
Exact-head verification for
No known proof gaps remain. Cancelled |
Closes #99734
What Problem This Solves
Fixes an issue where QA Smoke Gateway processes could fail to start or load generated modules when script-backed scenarios rebuilt the checkout's shared package output during the same run.
Why This Change Was Made
Script-backed scenarios now run only after flow Gateway work has completed. Playwright and Vitest scenarios keep their existing concurrent execution, limiting serialization to the process type that can mutate shared build output.
User Impact
Maintainers can validate mixed QA Smoke selections without intermittent missing
dist/index.jsor generated chunk failures caused by concurrent package rebuilds.Evidence
dist/files.37783c3502e427b47a24370af24fb4c50ef0c625.node scripts/run-vitest.mjs extensions/qa-lab/src/suite-launch.runtime.test.ts— 18 tests passed.tbx_01kwnag3bmv0rjd0e6p1hqyj93— passed; https://github.com/openclaw/openclaw/actions/runs/28690186588..agents/skills/autoreview/scripts/autoreview --mode branch --base origin/main --prompt-file /tmp/autoreview-context.md --stream-engine-output— no accepted/actionable findings.