fix(android): preserve numeric invoke error codes#99591
Merged
steipete merged 2 commits intoJul 3, 2026
Conversation
openclaw-barnacle
Bot
added
app: android
Contributor
|
Codex review: stale review; fresh review needed. Summary Next step |
openclaw-barnacle
Bot
removed
the
triage: needs-pr-context
ly85206559
force-pushed
the
codex/android-invoke-error-numeric-codes
branch
from
July 3, 2026 15:59
139a77f to
815788a
Compare
clawsweeper
Bot
added
rating: 🦪 silver shellfish
openclaw-barnacle
Bot
added
docs
steipete
marked this pull request as ready for review
July 3, 2026 18:15
steipete
force-pushed
the
codex/android-invoke-error-numeric-codes
branch
from
July 3, 2026 18:17
a7e96d8 to
5a50a30
Compare
openclaw-barnacle
Bot
added
size: XS
and removed
docs
Contributor
|
Maintainer closeout on exact head
Known proof boundary: the live A2UI command returns a structured invoke result directly; the throwable-normalization parser changed here is therefore covered by the focused unit regression, while the emulator/Gateway run proves the real numeric code and node transport. No screenshot attached because this PR has no UI change. |
Contributor
|
Merged via squash.
|
github-actions Bot
pushed a commit
to Desicool/openclaw
that referenced
this pull request
Jul 4, 2026
* fix(android): preserve numeric invoke error codes * fix(android): tighten invoke error code parsing --------- Co-authored-by: Peter Steinberger <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Problem This Solves
Android parses gateway invoke failures from
CODE: messagestrings so the UI can preserve stable error codes. The parser only accepted uppercase letters and underscores, so valid Android/gateway codes containing digits, such asA2UI_HOST_UNAVAILABLE, were downgraded toUNAVAILABLEand shown/classified as generic failures.Why This Change Was Made
Gateway and Android node errors already use canonical uppercase codes that can include digits. This change keeps the existing strict parser shape but allows digits alongside uppercase letters and underscores.
User Impact
Android users now see the specific A2UI/gateway error code instead of a generic unavailable error when the code contains a numeric component.
Evidence
JAVA_HOME='F:\Program Files\Android\Android Studio\jbr' ANDROID_HOME='F:\Android\Sdk' ANDROID_SDK_ROOT='F:\Android\Sdk' GRADLE_OPTS='-Xmx1g -Dfile.encoding=UTF-8' ./gradlew.bat --no-daemon :app:testPlayDebugUnitTest --tests ai.openclaw.app.gateway.InvokeErrorParserTest --console=plainpython .agents\skills\autoreview\scripts\autoreview --mode localreported clean with no accepted/actionable findings.