fix(android): normalize IPv6 zone IDs in gateway endpoint hosts#99560
Closed
ly85206559 wants to merge 1 commit into
Closed
fix(android): normalize IPv6 zone IDs in gateway endpoint hosts#99560ly85206559 wants to merge 1 commit into
ly85206559 wants to merge 1 commit into
Conversation
Strip interface zones during endpoint parsing so link-local URLs like ws://[fe80::1%25eth0] connect using socket-ready literals such as fe80::1. Co-authored-by: Cursor <[email protected]>
Contributor
|
ClawSweeper status: review started. I am starting a fresh review of this pull request: fix(android): normalize IPv6 zone IDs in gateway endpoint hosts This is item 1/1 in the current shard. Shard 0/1. This placeholder means the worker is alive and reading the current context. I will edit this same comment with the actual review when the claws are done clicking. Crustacean status: shell secured, claws on keyboard, evidence pebbles being sorted. |
Contributor
Author
|
Queued behind earlier Android fixes in this batch. Will open after prior PRs land. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Problem This Solves
IPv6 zone URLs such as
ws://[fe80::1%25eth0]passed cleartext validation but stored%25eth0in the connection host, which can break socket connect even though cleartext policy checks strip the zone.Why This Change Was Made
Normalize gateway endpoint hosts with
normalizeGatewayConnectionHostso parsed hosts are socket-ready literals likefe80::1.User Impact
Link-local IPv6 manual/QR gateway URLs connect using bare IPv6 literals.
Evidence
GatewayConfigResolverTest.parseGatewayEndpointAllowsLinkLocalIpv6ZoneCleartextWsUrlsGatewayConfigResolverTest.parseGatewayEndpointAllowsSecureIpv6ZoneUrlscd apps/android ./gradlew :app:testPlayDebugUnitTest --tests ai.openclaw.app.ui.GatewayConfigResolverTest.parseGatewayEndpointAllowsLinkLocalIpv6ZoneCleartextWsUrls --tests ai.openclaw.app.ui.GatewayConfigResolverTest.parseGatewayEndpointAllowsSecureIpv6ZoneUrls