fix(android): block self-package notification forwarding in allowlist mode#99559
Closed
ly85206559 wants to merge 1 commit into
Closed
fix(android): block self-package notification forwarding in allowlist mode#99559ly85206559 wants to merge 1 commit into
ly85206559 wants to merge 1 commit into
Conversation
… mode Always reject the OpenClaw app package in allowsPackage, matching the blocklist fail-closed behavior and preventing gateway/node forwarding loops. Co-authored-by: Cursor <[email protected]>
Contributor
|
ClawSweeper status: review started. I am starting a fresh review of this pull request: fix(android): block self-package notification forwarding in allowlist mode This is item 1/1 in the current shard. Shard 0/1. This placeholder means the worker is alive and reading the current context. I will edit this same comment with the actual review when the claws are done clicking. Crustacean status: shell secured, claws on keyboard, evidence pebbles being sorted. |
Contributor
Author
|
Queued behind #99557 and the talk-config PR. Will open after prior fixes land. |
This was referenced Jul 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Problem This Solves
Notification allowlist mode could forward OpenClaw's own notifications when the app package was allowlisted, risking gateway/node forwarding loops. Blocklist mode already blocked self by default.
Why This Change Was Made
Carry the app package through
NotificationForwardingPolicy.selfPackageNameand fail closed inallowsPackageregardless of filter mode.User Impact
Allowlists cannot accidentally forward OpenClaw app notifications to the gateway.
Evidence
NotificationForwardingPolicyTest.allowsPackage_neverForwardsSelfPackageEvenInAllowlistSecurePrefsNotificationForwardingTest.getNotificationForwardingPolicy_blocksSelfPackageInAllowlistModecd apps/android ./gradlew :app:testPlayDebugUnitTest --tests ai.openclaw.app.NotificationForwardingPolicyTest --tests ai.openclaw.app.SecurePrefsNotificationForwardingTest