fix(android): parse string booleans in talk gateway config#99558
Closed
ly85206559 wants to merge 1 commit into
Closed
fix(android): parse string booleans in talk gateway config#99558ly85206559 wants to merge 1 commit into
ly85206559 wants to merge 1 commit into
Conversation
Accept gateway talk config values like interruptOnSpeech: true using the same string boolean parsing used by TalkDirectiveParser and GatewaySession. Co-authored-by: Cursor <[email protected]>
Contributor
|
ClawSweeper status: review started. I am starting a fresh review of this pull request: fix(android): parse string booleans in talk gateway config This is item 1/1 in the current shard. Shard 0/1. This placeholder means the worker is alive and reading the current context. I will edit this same comment with the actual review when the claws are done clicking. Crustacean status: shell secured, claws on keyboard, evidence pebbles being sorted. |
Contributor
Author
|
Queued behind #99557. Will open a fresh PR after that lands. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Problem This Solves
Gateway talk config values like interruptOnSpeech: true
were ignored becauseTalkModeGatewayConfigParser` only accepted JSON boolean literals.Why This Change Was Made
Reuse the same string boolean parsing convention already used by
TalkDirectiveParserandGatewaySession.User Impact
Talk interrupt-on-speech honors string gateway config values.
Evidence
TalkModeConfigParsingTest.parsesStringInterruptOnSpeechFlagcd apps/android ./gradlew :app:testPlayDebugUnitTest --tests ai.openclaw.app.voice.TalkModeConfigParsingTest