fix: soften doctor shell completion install failures#99309
Conversation
|
Codex review: needs real behavior proof before merge. Reviewed July 3, 2026, 8:35 AM ET / 12:35 UTC. Summary PR surface: Source +37, Tests +52. Total +89 across 2 files. Reproducibility: yes. The linked issue provides EACCES logs, and current-main source shows doctor --fix can reach doctorShellCompletion, await installCompletion, and let a profile-write exception escape through runShellCompletionHealth; I did not run a live repro in this read-only pass. Review metrics: none identified. Stored data model Root-cause cluster Members:
Proposal only: this assessment does not dispatch repair, suppress jobs, mutate sibling items, close, or merge anything. Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Rank-up moves:
Proof guidance:
Risk before merge
Maintainer options:
Next step before merge
Security Review detailsBest possible solution: Land one canonical doctor-boundary fix that downgrades optional doctor completion install failures without changing the explicit completion installer contract. Do we have a high-confidence way to reproduce the issue? Yes. The linked issue provides EACCES logs, and current-main source shows doctor --fix can reach doctorShellCompletion, await installCompletion, and let a profile-write exception escape through runShellCompletionHealth; I did not run a live repro in this read-only pass. Is this the best way to solve the issue? Yes for the code boundary: doctorShellCompletion is the narrow place to downgrade optional doctor install failures while leaving completion --install fatal for explicit use. Weakening installCompletion itself would be broader than needed, and the update flow already catches optional refresh failures at its caller boundary. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against 414ecd2b9689. Label changesLabel justifications:
Evidence reviewedPR surface: Source +37, Tests +52. Total +89 across 2 files. View PR surface stats
What I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
|
|
Superseded by #99540, landed in The landed implementation keeps one centralized recovery path while selectively downgrading only wrapped Thanks @arkyu2077 for working on this bug. |
Summary
doctor --fixinto a non-blocking note~/.bashrcso doctor does not fail the whole runTesting
Closes #99237