fix(memory-wiki): avoid implicit error coercion#99307
Merged
Merged
Conversation
openclaw-barnacle
Bot
added
extensions: memory-wiki
size: XS
maintainer
github-actions Bot
pushed a commit
to Desicool/openclaw
that referenced
this pull request
Jul 3, 2026
sheyanmin
pushed a commit
to sheyanmin/openclaw
that referenced
this pull request
Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes broken ci lint on main
What Problem This Solves
The extension lint gate fails on
extensions/memory-wiki/src/ingest.tsbecause the existing-source error predicate uses implicit boolean coercion. Since extension lint runs across the full bundled plugin surface, the failure blocks otherwise unrelated pull requests.Why This Change Was Made
Replaces
!!errorwith an explicit non-null object guard. This satisfiesno-implicit-coercionwhile preserving the predicate's existingENOENTandEISDIRbehavior.User Impact
No user-visible behavior change. Pull requests can pass the bundled extension lint gates again.
Evidence
extensions/memory-wiki/src/ingest.ts.node scripts/run-vitest.mjs extensions/memory-wiki/src/wiki-notes-read-retry.test.ts --reporter=verbose— 1 file, 9 tests passed.