fix(zalo): match native bot identity fields#99274
Conversation
|
Codex review: needs maintainer review before merge. Reviewed July 2, 2026, 8:55 PM ET / 00:55 UTC. Summary PR surface: Source +1, Tests +22. Total +23 across 3 files. Reproducibility: yes. Current main reads Review metrics: none identified. Root-cause cluster Members:
Proposal only: this assessment does not dispatch repair, suppress jobs, mutate sibling items, close, or merge anything. Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Rank-up moves:
Risk before merge
Maintainer options:
Next step before merge
Security Review detailsBest possible solution: Land this focused Zalo plugin fix after ordinary maintainer and CI gates, keeping the native getMe fields as the canonical runtime shape. Do we have a high-confidence way to reproduce the issue? Yes. Current main reads Is this the best way to solve the issue? Yes. Updating the Zalo plugin type and the one startup-label consumer is the narrowest maintainable fix; adding a legacy AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against 9238d9aeae8d. Label changesLabel justifications:
Evidence reviewedPR surface: Source +1, Tests +22. Total +23 across 3 files. View PR surface stats
What I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
|
Summary
ZaloBotInfowith the official Zalo Bot PlatformgetMeresponseaccount_namefor the gateway startup labelid,account_name,account_type, andcan_join_groupsfieldsOfficial contract: https://bot.zapps.me/docs/apis/getMe/
Stack
Tests
node scripts/run-vitest.mjs extensions/zalo/src/api.test.tspnpm format:check extensions/zalo/src/api.ts extensions/zalo/src/api.test.ts extensions/zalo/src/channel.runtime.tsgit diff --check.agents/skills/autoreview/scripts/autoreview --mode branch --stream-engine-output(clean, no actionable findings)