fix(android): strip ws scheme prefix from manual gateway host input#99110
Merged
steipete merged 3 commits intoJul 2, 2026
Merged
Conversation
Contributor
|
Codex review: needs maintainer review before merge. Reviewed July 2, 2026, 2:40 PM ET / 18:40 UTC. Summary PR surface: Other +79. Total +79 across 2 files. Reproducibility: yes. Source inspection shows current Review metrics: none identified. Root-cause cluster Members:
Proposal only: this assessment does not dispatch repair, suppress jobs, mutate sibling items, close, or merge anything. Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Rank-up moves:
Risk before merge
Maintainer options:
Next step before merge
Security Review detailsBest possible solution: Land the endpoint-preservation fix after current-head Android CI finishes, keeping full URL handling in the shared Android resolver and preserving the IPv6 authority helper from current Do we have a high-confidence way to reproduce the issue? Yes. Source inspection shows current Is this the best way to solve the issue? Yes. Preserving a complete pasted endpoint in the existing manual composer is narrower and safer than stripping schemes, because it keeps the endpoint parser as the single validation path and preserves IPv6 authority formatting from current AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against 97ad0b7c211c. Label changesLabel changes:
Label justifications:
Evidence reviewedPR surface: Other +79. Total +79 across 2 files. View PR surface stats
What I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
|
clawsweeper
Bot
added
rating: 🧂 unranked krab
Reject bare ws:// in the Host field and normalize pasted ws:// LAN URLs so manual onboarding resolves the real hostname instead of host ws. Fixes openclaw#87216. Co-authored-by: Cursor <[email protected]>
steipete
force-pushed
the
fix/android-manual-gateway-ws-scheme-host
branch
from
July 2, 2026 18:31
6b46995 to
062a9da
Compare
Contributor
|
Maintainer verification Before — pasting the complete WebSocket endpoint is rejected as an invalid gateway URL. 
After — the same endpoint is accepted and advances to Gateway Recovery. 
Maintainer rewrite:
Validation:
Proof gap: no live Gateway service was started; the real app path was verified through exact endpoint acceptance into connection recovery. Fixes #87216. |
clawsweeper
Bot
added
proof: sufficient
Contributor
|
Merged via squash.
|
github-actions Bot
pushed a commit
to Desicool/openclaw
that referenced
this pull request
Jul 3, 2026
…penclaw#99110) * fix(android): strip ws scheme prefix from manual gateway host input Reject bare ws:// in the Host field and normalize pasted ws:// LAN URLs so manual onboarding resolves the real hostname instead of host ws. Fixes openclaw#87216. Co-authored-by: Cursor <[email protected]> * fix(android): preserve complete manual gateway endpoints * fix(android): preserve gateway i18n inventory --------- Co-authored-by: Cursor <[email protected]> Co-authored-by: Peter Steinberger <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Problem This Solves
Fixes #87216. Manual gateway onboarding advertised private LAN
ws://support, but users who typedws://(or pastedws://192.168.x.x) into the Host field got resolved endpoints likehttp://ws:18789, leading toprotocol mismatchbefore pairing could succeed.Why This Change Was Made
Add
normalizeManualGatewayHostInputto strip accidentalws:///wss:///http(s)://prefixes from the manual Host field, reject bare scheme-only input, and reuse the existing endpoint parser on the normalized hostname.User Impact
Manual LAN setup now resolves
HOST=ws://192.168.178.57,PORT=18789,TLS=offto host192.168.178.57instead of hostws. Barews://in Host is rejected instead of silently mis-parsing.Evidence
GatewayConfigResolverTest.kt:normalizeManualGatewayHostInput_rejectsBareWsSchemePrefixcomposeGatewayManualUrl_acceptsLanHostWithWsSchemePrefixresolveGatewayConnectConfigManual_acceptsLanHostWithWsSchemePrefixcd apps/android ./gradlew :app:testPlayDebugUnitTest --tests ai.openclaw.app.ui.GatewayConfigResolverTest