fix(message): thread --limit through to CLI formatter and surface provider pagination hints#99089
Conversation
|
Codex review: needs maintainer review before merge. Reviewed July 2, 2026, 8:57 PM ET / 00:57 UTC. Summary PR surface: Source +66, Tests +191. Total +257 across 3 files. Reproducibility: yes. Current main exposes Review metrics: none identified. Root-cause cluster Members:
Proposal only: this assessment does not dispatch repair, suppress jobs, mutate sibling items, close, or merge anything. Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Rank-up moves:
Risk before merge
Maintainer options:
Next step before merge
Security Review detailsBest possible solution: Land this narrow formatter and CLI bridge fix after maintainer review, and track any broader cross-provider cursor iteration separately if maintainers still want it. Do we have a high-confidence way to reproduce the issue? Yes. Current main exposes Is this the best way to solve the issue? Yes for the central bug. The shared formatter plus CLI bridge is the narrowest maintainable boundary for the display cap, while broader provider cursor UX can remain separate. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against 9238d9aeae8d. Label changesLabel justifications:
Evidence reviewedPR surface: Source +66, Tests +191. Total +257 across 3 files. View PR surface stats
What I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
|
|
@clawsweeper re-review |
|
🦞🧹 I asked ClawSweeper to review this item again. |
85783ca to
6672371
Compare
…vider pagination hints
6672371 to
3364c11
Compare
4029f1c
into
openclaw:main
* origin/main: (1287 commits) fix(android): block loopback canvas navigation (openclaw#99874) fix(hooks): suppress unhandled stdout/stderr stream errors in gmail watcher (openclaw#100519) fix(memory-core): guard qmd mcporter JSON.parse against non-JSON stdout (openclaw#98381) fix(build): fall back to tsx for build TypeScript scripts (openclaw#91262) feat(skills): suggest saving detected reusable workflows by default (openclaw#95477) (openclaw#100692) docs(changelog): remove generated release-note entries feat(telegram): offer BotFather web app flow in setup help and docs (openclaw#100540) fix(ios): unify Talk and Settings row typography on one branded detail row (openclaw#100515) feat(gateway): add persisted crash-loop breaker and fatal-config exit contract refactor(macos): lock and unify PortGuardian tunnel record persistence so concurrent app instances cannot lose orphan records (openclaw#100601) fix: stop reconnecting on protocol mismatch (openclaw#98414) fix(maint): reuse recent hosted gates after rebase (openclaw#100663) fix(ui): reopen web terminals without stale content (openclaw#100665) fix(browser): diagnose empty WSL2 Chrome replies (openclaw#100590) fix(ios): chat snaps back to bottom when scrolling to top via status-bar tap (openclaw#100502) Treat already-compacted CLI compaction as no-op (openclaw#99136) docs(changelog): remove direct main fix entry fix(feishu): strip internal tool-trace banners from outbound text (openclaw#98705) fix(message): thread --limit through to CLI formatter and surface provider pagination hints (openclaw#99089) fix(voyage): close response body stream when batch output JSONL parsing throws (openclaw#98840) ... # Conflicts: # extensions/memory-wiki/package.json
…vider pagination hints (openclaw#99089)
…vider pagination hints (openclaw#99089)
What Problem This Solves
Refs #71452
The CLI text renderer hard-coded
messages.slice(0, 25), so message reads and pin lists could display only 25 rows even when the provider returned more and the user requested a higher--limit.This is a partial fix for #71452. It removes the formatter bottleneck and surfaces existing pagination metadata, but it does not add end-to-end provider pagination or cursor iteration. Discord search remains limited to one page of up to 25 results; broader pagination stays tracked in #71452.
Why This Change Was Made
The change forwards the parsed CLI
--limitinto the shared message formatter while preserving the existing default of 25 rows. It also shows a hint when provider response metadata indicates that more results exist.For Discord search,
total_resultscan indicate that additional matches exist, but it is not a cursor and this PR does not implement Discord's offset-based pagination.User Impact
message readandmessage pinscan render more than 25 rows when the provider returns them and the user requests a higher limit.--limitis omitted.Evidence
3364c11fd616e872c800a81ecac2802249dc4462.