fix(config): enable repaired external plugins whose id matches built-in channel by yaotukeji · Pull Request #98975 · openclaw/openclaw

yaotukeji · 2026-07-02T07:17:58Z

What Problem This Solves

After Mattermost was externalized in 2026.6.11, running openclaw doctor --fix on an upgraded container installs @openclaw/mattermost but does not enable it for gateway startup. The gateway starts with only 7 plugins and silently omits Mattermost, causing message loss. The root cause is that materializePluginAutoEnableCandidates writes the activation bit to channels.mattermost.enabled because "mattermost" is also a built-in channel id, but gateway startup for non-bundled plugins requires plugins.entries.mattermost.enabled=true.

Changes

src/config/plugin-auto-enable.shared.ts: make resolveAutoEnableChannelId return null for configured-plugin-repaired candidates, so activation is written to plugins.entries.<id>.enabled.
src/config/plugin-auto-enable.core.test.ts: add regression test covering a repaired external plugin whose id matches a built-in channel id.

Evidence

Added a focused regression test that asserts plugins.entries.mattermost.enabled is true and channels.mattermost.enabled is not set for a configured-plugin-repaired candidate.
Existing test suites still pass:
- src/config/plugin-auto-enable.core.test.ts: 52 passed
- src/commands/doctor/repair-sequencing.test.ts: 15 passed
Manual reproduction from the issue matches the observed regression path.

…in channel When doctor --fix repairs a configured external plugin whose pluginId coincides with a built-in chat channel id (e.g. mattermost), materializePluginAutoEnableCandidates was writing the activation bit to channels.<id>.enabled instead of plugins.entries.<id>.enabled. Gateway startup only honors the plugin entry for non-bundled plugins, so the repaired plugin was silently omitted. This change makes resolveAutoEnableChannelId return null for configured-plugin-repaired candidates, so the activation is materialized as plugins.entries.<id>.enabled=true. Fixes openclaw#98564 Co-Authored-By: Claude Opus 4.6 <[email protected]>

clawsweeper · 2026-07-02T07:34:16Z

Thanks for the context here. I swept through the related work, and this is now duplicate or superseded.

Close: this PR is superseded by the merged canonical fix in #98608, and current main already has the requested repaired-external-plugin activation behavior with broader coverage.

Root-cause cluster
Relationship: superseded
Canonical: #98608
Summary: This PR and the merged canonical PR target the same Mattermost configured-plugin repair regression; the canonical PR is merged and current main contains same-or-better behavior.

Members:

canonical: fix: Mattermost fails to load after configured plugin repair #98608 - Merged PR for the same Mattermost configured-plugin repair issue with broader current-main coverage.
fixed_by_candidate: [Bug]: Mattermost repair installs external plugin without enabling gateway startup #98564 - Closed canonical bug report whose Docker upgrade reproduction is fixed by the merged canonical PR.

Proposal only: this assessment does not dispatch repair, suppress jobs, mutate sibling items, close, or merge anything.

Canonical path: Keep #98608 as the canonical merged fix and close this redundant branch rather than landing a second overlapping activation change.

So I’m closing this here and keeping the remaining discussion on #98608.

Review details

Best possible solution:

Keep #98608 as the canonical merged fix and close this redundant branch rather than landing a second overlapping activation change.

Do we have a high-confidence way to reproduce the issue?

Yes for the original shipped regression: the linked issue gives concrete 2026.6.10 to 2026.6.11 Docker logs, and source shows non-bundled gateway startup requires explicit plugin activation. Current main now contains the repaired activation path.

Is this the best way to solve the issue?

Yes, the merged implementation in #98608 is the better current solution because it covers this repaired-plugin case plus same-id external channel and allowlist/fallback invariants. This PR should not land separately.

Security review:

Security review cleared: Cleared: the diff only touches config auto-enable logic and a colocated test, with no new dependency, workflow, secret, or supply-chain surface.

AGENTS.md: found and applied where relevant.

What I checked:

Current source implements requested activation routing: Current main returns null for configured-plugin-repaired before built-in channel-id routing, so repaired plugin candidates materialize under plugins.entries.<id>.enabled instead of channels.<id>.enabled. (src/config/plugin-auto-enable.shared.ts:864, 019603d33602)
Current tests cover the same repaired Mattermost path: Current main has a regression test asserting repaired external Mattermost candidates enable plugins.entries.mattermost.enabled and leave channels.mattermost.enabled unset. (src/config/plugin-auto-enable.channels.test.ts:208, 019603d33602)
Current tests cover a broader upgrade policy case: The merged canonical fix also covers restrictive plugin allowlist behavior for repaired external channel plugins, which this PR does not cover. (src/config/plugin-auto-enable.channels.test.ts:240, 019603d33602)
Doctor repair caller feeds repaired ids into the materializer: Doctor repair maps repaired plugin ids to configured-plugin-repaired candidates before calling materializePluginAutoEnableCandidates, which is the path this PR and the merged fix both target. (src/commands/doctor/repair-sequencing.ts:122, 019603d33602)
Gateway startup still requires explicit external plugin activation: Gateway startup returns true for non-bundled plugins only when activation is enabled and explicitly enabled, confirming why plugins.entries.<id>.enabled=true is the needed contract. (src/plugins/gateway-startup-plugin-ids.ts:1870, 019603d33602)
Merged canonical PR supersedes this branch: Live GitHub data shows fix: Mattermost fails to load after configured plugin repair #98608 is merged and closed the same Mattermost configured-plugin repair issue that this PR references. (c032f9809d78)

Likely related people:

jacobtomlinson: Authored the merged fix commit for the repaired Mattermost activation path and opened the canonical issue with the Docker upgrade reproduction. (role: canonical fix author and reproduction owner; confidence: high; commits: 48f4a09e1fd8; files: src/config/plugin-auto-enable.shared.ts, src/config/plugin-auto-enable.channels.test.ts)
shakkernerd: Committed the follow-up allowlist/fallback coverage in the same merged stack and is the committer on the canonical merge commit. (role: recent adjacent contributor and merger; confidence: high; commits: d2d20b5fed41, c032f9809d78; files: src/config/plugin-auto-enable.shared.ts, src/config/plugin-auto-enable.channels.test.ts)

Codex review notes: model internal, reasoning high; reviewed against 019603d33602; fix evidence: commit 48f4a09e1fd8, main fix timestamp 2026-07-02T17:13:38+01:00.

The regression test for issue openclaw#98564 used origin: 'npm', but PluginOrigin only accepts bundled | global | workspace | config. This caused check-test-types to fail with TS2322. Use 'global' to represent the externalized Mattermost plugin. Co-Authored-By: Claude Opus 4.6 <[email protected]>

…-enable-gateway-startup

clawsweeper · 2026-07-02T16:57:44Z

ClawSweeper applied the proposed close for this PR.

Action: closed this PR.
Close reason: duplicate or superseded.
Evidence: durable ClawSweeper review.
Coverage proof: PR B clearly carries PR A's core behavior and is already merged as the broader/current canonical implementation, so any remaining proof or review discussion belongs on PR B rather than keeping PR A open. Covering PR: fix: Mattermost fails to load after configured plugin repair #98608.

openclaw-barnacle Bot added size: S triage: needs-pr-context Candidate: external PR body lacks required problem context or evidence. and removed triage: needs-pr-context Candidate: external PR body lacks required problem context or evidence. labels Jul 2, 2026

clawsweeper Bot mentioned this pull request Jul 2, 2026

fix: Mattermost fails to load after configured plugin repair #98608

Merged

clawsweeper Bot added rating: 🧂 unranked krab Not merge-ready due to missing proof or serious correctness/safety concerns. and removed rating: 🦪 silver shellfish Thin PR readiness signal; proof, validation, or implementation needs work. labels Jul 2, 2026

Merge remote-tracking branch 'origin/main' into fix/mattermost-repair…

28884ab

…-enable-gateway-startup

openclaw-barnacle Bot added size: XS and removed size: S labels Jul 2, 2026

clawsweeper Bot closed this Jul 2, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

fix(config): enable repaired external plugins whose id matches built-in channel#98975

fix(config): enable repaired external plugins whose id matches built-in channel#98975
yaotukeji wants to merge 3 commits into
openclaw:mainfrom
yaotukeji:fix/mattermost-repair-enable-gateway-startup

yaotukeji commented Jul 2, 2026 •

edited

Loading

Uh oh!

clawsweeper Bot commented Jul 2, 2026 •

edited

Loading

Uh oh!

clawsweeper Bot commented Jul 2, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Uh oh!

Conversation

yaotukeji commented Jul 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What Problem This Solves

Changes

Evidence

Related

Uh oh!

clawsweeper Bot commented Jul 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

clawsweeper Bot commented Jul 2, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

yaotukeji commented Jul 2, 2026 •

edited

Loading

clawsweeper Bot commented Jul 2, 2026 •

edited

Loading