Skip to content

Park channel plugin blocker dry-run effects#98869

Draft
giodl73-repo wants to merge 2 commits into
openclaw:mainfrom
giodl73-repo:doctor-channel-plugin-blocker-dry-run-effects
Draft

Park channel plugin blocker dry-run effects#98869
giodl73-repo wants to merge 2 commits into
openclaw:mainfrom
giodl73-repo:doctor-channel-plugin-blocker-dry-run-effects

Conversation

@giodl73-repo

@giodl73-repo giodl73-repo commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Status

Parked after review.

Omar correctly pointed out that the channel-plugin-blocker structured dry-run repair effect was not reachable from a supported Doctor CLI path. This PR was only that dry-run backfill, so the branch now contains a revert commit and has an empty diff against main.

Current branch state

  • Head: 9c44766ab5
  • Diff against origin/main: empty
  • git diff --check: passed

Next step

Close or leave parked until core structured repair/dry-run has a supported entry point. Reintroduce channel plugin blocker dry-run effects only after that substrate exists.

@openclaw-barnacle openclaw-barnacle Bot added commands Command implementations size: S labels Jul 2, 2026
@giodl73-repo

Copy link
Copy Markdown
Contributor Author

@clawsweeper review current head 8bfdd86f37c1708aef619344d7f16279f0e9c426. Adds structured dry-run repair effects for channel plugin blocker findings while leaving real plugin enablement as an explicit operator action. Focused proof is listed in the PR body.

@openclaw-barnacle openclaw-barnacle Bot added the maintainer Maintainer-authored PR label Jul 2, 2026
@clawsweeper

clawsweeper Bot commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

🦞🧹
ClawSweeper re-review requested.

I asked ClawSweeper to review this item again.
Action: item re-review queued (workflow sweep.yml, event repository_dispatch).
Result: the existing ClawSweeper review comment will be edited in place when the review finishes.

@clawsweeper

clawsweeper Bot commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Codex review: stale review; fresh review needed.

Summary
The latest durable ClawSweeper review was for head 8bfdd86f37017ea417945eb80e2c68656ecd0efe, but the PR head is now 9c44766ab51a5ba7fefa58960d1767020c6f3c6f. Its old verdict and PR readiness labels are no longer current.

Next step
Run or wait for a fresh ClawSweeper review on the current PR head.

Review history (1 earlier review cycle)
  • reviewed 2026-07-02T03:16:33.246Z sha 8bfdd86 :: needs real behavior proof before merge. :: none

@clawsweeper clawsweeper Bot added rating: 🦪 silver shellfish Thin PR readiness signal; proof, validation, or implementation needs work. status: 📣 needs proof The PR needs real behavior proof before ClawSweeper can clear the contributor ask. P3 Low-priority cleanup, docs, polish, ergonomics, or speculative work. labels Jul 2, 2026
@omarshahine

Copy link
Copy Markdown
Contributor

Codex review finding:

The dry-run effect added for core/doctor/channel-plugin-blockers is not reachable from a supported Doctor command. The check adds a repair() implementation (src/flows/doctor-health-contributions.ts:1640-1667), but the contribution still supplies run: runStartupChannelMaintenanceHealth (src/flows/doctor-health-contributions.ts:1669). createDoctorHealthContribution only invokes runStructuredDoctorHealthContribution when run is omitted (src/flows/doctor-health-contributions.ts:144-151), so the new effect is skipped by openclaw doctor --fix. The shared structured repair pass only selects extension checks (src/flows/doctor-health-contributions.ts:440-453, src/flows/health-check-registry.ts:29-40), and the CLI makes --only a lint-only option (src/cli/program/register.maintenance.ts:42-83); there is no doctor fix --dry-run --only core/doctor/channel-plugin-blockers command path.

Best fix: wire this core check into an actual structured repair/dry-run entry point, or keep the blocker check detect-only and remove the unreachable repair effect/tests/body claim.

@giodl73-repo

Copy link
Copy Markdown
Contributor Author

Accepted Omar's reachability finding and parked this PR.

This PR was only the structured dry-run backfill for core/doctor/channel-plugin-blockers. Since that repair hook is not reachable from a supported Doctor CLI path today, I reverted the PR content in 9c44766ab5 rather than leaving a misleading dry-run effect claim.

Current branch state:

  • Diff against origin/main is empty.
  • git diff --check passes.

Recommended next step: keep this PR parked/close it, and reintroduce channel plugin blocker dry-run effects only after we add a real supported core structured repair/dry-run entry point.

@clawsweeper clawsweeper Bot added rating: 🌊 off-meta tidepool PR readiness rating does not apply to this item. status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR. and removed rating: 🦪 silver shellfish Thin PR readiness signal; proof, validation, or implementation needs work. status: 📣 needs proof The PR needs real behavior proof before ClawSweeper can clear the contributor ask. labels Jul 2, 2026
@giodl73-repo giodl73-repo changed the title Preview channel plugin blocker dry-run effects Park channel plugin blocker dry-run effects Jul 2, 2026
@clawsweeper clawsweeper Bot removed rating: 🌊 off-meta tidepool PR readiness rating does not apply to this item. status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR. labels Jul 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

commands Command implementations maintainer Maintainer-authored PR P3 Low-priority cleanup, docs, polish, ergonomics, or speculative work. size: XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants