Park channel plugin blocker dry-run effects#98869
Conversation
|
@clawsweeper review current head 8bfdd86f37c1708aef619344d7f16279f0e9c426. Adds structured dry-run repair effects for channel plugin blocker findings while leaving real plugin enablement as an explicit operator action. Focused proof is listed in the PR body. |
|
🦞🧹 I asked ClawSweeper to review this item again. |
|
Codex review: stale review; fresh review needed. Summary Next step Review history (1 earlier review cycle)
|
|
Codex review finding: The dry-run effect added for Best fix: wire this core check into an actual structured repair/dry-run entry point, or keep the blocker check detect-only and remove the unreachable repair effect/tests/body claim. |
This reverts commit 8bfdd86.
|
Accepted Omar's reachability finding and parked this PR. This PR was only the structured dry-run backfill for Current branch state:
Recommended next step: keep this PR parked/close it, and reintroduce channel plugin blocker dry-run effects only after we add a real supported core structured repair/dry-run entry point. |
Status
Parked after review.
Omar correctly pointed out that the channel-plugin-blocker structured dry-run repair effect was not reachable from a supported Doctor CLI path. This PR was only that dry-run backfill, so the branch now contains a revert commit and has an empty diff against
main.Current branch state
9c44766ab5origin/main: emptygit diff --check: passedNext step
Close or leave parked until core structured repair/dry-run has a supported entry point. Reintroduce channel plugin blocker dry-run effects only after that substrate exists.